Bug 325270 - [content assist] Parameter names are not displayed for static inner class of an external jar
Summary: [content assist] Parameter names are not displayed for static inner class of ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 11:19 EDT by Satyam Kandula CLA
Modified: 2010-09-21 17:57 EDT (History)
3 users (show)

See Also:
amj87.iitr: review+

Attachments
Jar file to add in build path (1.59 KB, application/x-java-archive)
2010-09-14 11:19 EDT, Satyam Kandula CLA 		no flags Details
Proposed fix (4.82 KB, patch)
2010-09-14 11:51 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix + regression test (8.25 KB, patch)
2010-09-14 12:22 EDT, Olivier Thomann CLA 		no flags Details | Diff
New external library jar (1.59 KB, application/octet-stream)
2010-09-14 12:23 EDT, Olivier Thomann CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satyam Kandula CLA 2010-09-14 11:19:23 EDT 
Created attachment 178845 [details]
Jar file to add in build path

This is actually a FUP of bug 316937. 
bug 316937 does take care of inner classes of a jar, but doesn't work if the inner class is static! 

Use the attached jar file and try 
########
class Test {
 void test() {
    new pkg.Foo1.Bar1([CTRL-SPACE
 }
}
##########
Comment 1 Olivier Thomann CLA 2010-09-14 11:29:12 EDT 
I'll take a look.
Comment 2 Olivier Thomann CLA 2010-09-14 11:51:57 EDT 
Created attachment 178848 [details]
Proposed fix

I need to add regression test for this case.
Comment 3 Olivier Thomann CLA 2010-09-14 12:22:25 EDT 
Created attachment 178850 [details]
Proposed fix + regression test

Same fix with regression test.
Comment 4 Olivier Thomann CLA 2010-09-14 12:23:30 EDT 
Created attachment 178851 [details]
New external library jar

Jar file to put in /org.eclipse.jdt.core.tests.model/workspace/Completion
Comment 5 Ayushman Jain CLA 2010-09-15 11:04:06 EDT 
Patch looks good.
Comment 6 Olivier Thomann CLA 2010-09-15 11:37:29 EDT 
Released for 3.7M2.
Added regression test in:
org.eclipse.jdt.core.tests.model.CompletionTests#testCompletionMethodDeclaration17
Comment 7 Olivier Thomann CLA 2010-09-21 17:57:29 EDT 
Verified using I20100921-1024