Bug 324840 - [compiler] Improving debug strings for Break statement, IntLiteral and CaseStatement
Summary: [compiler] Improving debug strings for Break statement, IntLiteral and CaseSt...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 08:43 EDT by Elmar Chen CLA
Modified: 2010-09-15 10:02 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (2.80 KB, patch)
2010-09-10 15:20 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix + regression tests (12.70 KB, patch)
2010-09-10 22:40 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elmar Chen CLA 2010-09-09 08:43:38 EDT 
Build Identifier: 20090818-0235

in File eclipse-source/src/plugins/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/CaseStatement.java, method printStatement, in the return statement, I think there shall not have ";" appended.




Reproducible: Always

Steps to Reproduce:
1.source code.
Comment 1 Olivier Thomann CLA 2010-09-10 15:20:58 EDT 
Created attachment 178648 [details]
Proposed fix

Need to check that no test is impacted and also modified the break statement to display better.
Comment 2 Olivier Thomann CLA 2010-09-10 22:40:08 EDT 
Created attachment 178670 [details]
Proposed fix + regression tests

Updated all regression tests.
Comment 3 Olivier Thomann CLA 2010-09-13 09:20:13 EDT 
Released for 3.7M2.
Updated existing regression tests.
Comment 4 Ayushman Jain CLA 2010-09-15 03:37:55 EDT 
Olivier, its not clear to me why the constructor for IntLiteral and its printExpression were removed here. I dont see any clear correlation to this bug as such. Were they removed because they are not used anywhere?
Comment 5 Olivier Thomann CLA 2010-09-15 08:12:41 EDT 
(In reply to comment #4)
> Olivier, its not clear to me why the constructor for IntLiteral and its
> printExpression were removed here. I dont see any clear correlation to this bug
> as such. Were they removed because they are not used anywhere?
Yes, we used to use this old constructor, but we don't anymore. So for clean up this I removed them.
Comment 6 Ayushman Jain CLA 2010-09-15 10:02:01 EDT 
Verified for 3.7M2 using code inspection.