Bug 32469 - disabled breakpoints still rendered as enabled
Summary: disabled breakpoints still rendered as enabled
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P1 major (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 32694 32812 33146 33674 33905 33914 34030 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-02-21 06:37 EST by Adam Kiezun CLA
Modified: 2003-03-06 17:26 EST (History)
7 users (show)

See Also:

Attachments
Patch for the bug (626 bytes, patch)
2003-02-24 04:03 EST, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2003-02-21 06:37:46 EST 
20030221
disable a breakpoint - icon does not change
but the breakpoint is disabled

major - renders the important feature not very useful
Comment 1 Darin Swanson CLA 2003-02-21 09:18:44 EST 
The breakpoint shows as disabled in the breakpoints view.
It does not show as disabled in the editor ruler. Points to a problem in 
another component.
If the editor is closed and reopened, the breakpoint is rendered with the 
disabled icon.
Adam can you ask around in ZRH if this is likely a JDT UI or Text change 
problem?
Comment 2 Darin Wright CLA 2003-02-21 09:25:44 EST 
Is there anything in the .log?
Comment 3 Darin Swanson CLA 2003-02-21 09:29:39 EST 
I have nothing in my log when I see the problem.
Comment 4 Adam Kiezun CLA 2003-02-21 09:38:12 EST 
nope, nothing in the log, i think

no, nothing obvious on our side - but anything is possible
Comment 5 Darin Wright CLA 2003-02-21 10:13:10 EST 
I have verified that the JavaMarkerAnnotation is not asking for the new image 
when the breakpoint state changes. However, I am not sure why. The source code 
looks like it should be - but when I step over the line, the execution jumps to 
a blank line. Very strange - I will have to get the real source (instead of 
binary plug-in) to see what is going on...
Comment 6 Darin Wright CLA 2003-02-21 10:27:55 EST 
I beleive the problem is coming from the annotation update code in either JUI 
or JFACE text. I am not familiar with the code, but I have verified that the 
marker delta is being processed by the annotation model, but never asks for the 
new breakpoint image.
Comment 7 Darin Wright CLA 2003-02-21 10:58:56 EST 
The stepping problem I saw (in comment #5), was due to a PDE source lookup bug. 
Once I changed the PDE preferences, my source matched the classfiles. I see 
that the old code used to set a new breakpoint image in 
JavaMarkerAnnotation#initialize(), but the new code only sets an image type. 
Since breakpoint images have state (i.e. more than one state), this does not 
seem sufficient (but I am not familiar with the code).
Comment 8 Dani Megert CLA 2003-02-22 11:05:43 EST 
This could be a regression which was introduced by fixing bug 29696.
Quick fix would be to revert to the previous version of JavaMarkerAnnotation.
Comment 9 Dani Megert CLA 2003-02-24 04:03:47 EST 
Created attachment 3666 [details]
Patch for the bug
Comment 10 Darin Swanson CLA 2003-02-24 11:37:30 EST 
*** Bug 32694 has been marked as a duplicate of this bug. ***
Comment 11 Darin Swanson CLA 2003-02-24 16:27:53 EST 
*** Bug 32812 has been marked as a duplicate of this bug. ***
Comment 12 Darin Wright CLA 2003-02-25 17:09:39 EST 
*** Bug 33146 has been marked as a duplicate of this bug. ***
Comment 13 Dani Megert CLA 2003-02-27 03:59:13 EST 
Fixed in builds >= I20030227
Comment 14 Darin Wright CLA 2003-03-03 11:12:02 EST 
*** Bug 33674 has been marked as a duplicate of this bug. ***
Comment 15 Darin Wright CLA 2003-03-05 15:41:41 EST 
*** Bug 33905 has been marked as a duplicate of this bug. ***
Comment 16 Darin Wright CLA 2003-03-05 16:53:57 EST 
*** Bug 33914 has been marked as a duplicate of this bug. ***
Comment 17 Darin Wright CLA 2003-03-06 17:26:21 EST 
*** Bug 34030 has been marked as a duplicate of this bug. ***