Bug 323848 - Merge Make Targets view into Navigator
Summary: Merge Make Targets view into Navigator
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: cdt-build-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 11:31 EDT by Doug Schaefer CLA
Modified: 2020-09-04 15:26 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Schaefer CLA 2010-08-27 11:31:02 EDT
Once we get build configurations into the Navigator, we should also bring Make targets over.

We need to brain storm about how this would work but we could do a number of things:

- Add make targets as children to the build configs (Bug 322175).
- Add make targets as children of the Makefiles themselves.
- Add make targets as children of the folder where the build will run (which I believe is the same as we have today.

Of course, we'd add "New Make Target" menu items to parent nodes in the navigator, but only if the project (or one of it's configs, which is why the config probably needs to a root node) has a "Makefile" project type.
Comment 1 Doug Schaefer CLA 2010-08-27 11:34:03 EDT
BTW, I'm not committing to this for CDT 8.0. If someone else wants to pick it up, you're free to it.
Comment 2 Andrew Gvozdev CLA 2010-08-27 11:58:30 EDT
It is attractive idea to have make targets in Project Explorer and probably will work well for smaller projects. For big projects we still need the Make Targets view as it is cumbersome to move along PE tree every time you need to build if there are hundreds of files. It could probably use common code though.
I got an old screenshot how it may look like in bug 238919, throwing here for brainstorming.
Comment 3 Doug Schaefer CLA 2010-08-27 14:13:22 EDT
We definitely need to find a way to keep it less cumbersome or at least no less than it is today.

I also want to cut down putting things in the UI that don't always make sense. We suffer from having too many views in Eclipse. For customers who don't need those views and get confused and/or annoyed by their presence, we should make sure we don't show them. And if we can make that context specific, as the navigator provides, that would be even better. If a customer never uses makefile projects or uses an alternative build system that doesn't have make targets, why would we show them this view?
Comment 4 Doug Schaefer CLA 2016-08-15 15:18:09 EDT
Funny this bug is still here. I have it ready to go. The change will add a common navigator extension for IMakeTargets adding them to IContainers and ICContainers. I am also changing the name from Make Target to Build Target. All the menu items carry over. I've added a "Build Targets" virtual node to the tree to hold all the make targets for a given container.
Comment 5 Doug Schaefer CLA 2016-08-15 15:24:37 EDT
I am leaving the Make Target view for now, renaming it to Build Targets. In theory we don't need it any more but I have a couple of people who found it useful.
Comment 6 Eclipse Genie CLA 2016-08-15 15:31:17 EDT
New Gerrit change created: https://git.eclipse.org/r/79081
Comment 8 Marc Khouzam CLA 2016-08-17 10:14:54 EDT
Thanks Doug for this.  Could you update the N&N please:
https://wiki.eclipse.org/CDT/User/NewIn91

I'll use that info for the release review of 9.1.
Comment 9 Jonah Graham CLA 2019-12-30 17:05:20 EST
This bug was assigned and targeted at a now released milestone. As that milestone has now passed, the milestone field has been cleared. If this bug has been fixed, please set the milestone to the version it was fixed in and marked the bug as resolved.