Bug 323796 - [SaveDeltaWizard] Allow to override existing file and suggest containing resource
Summary: [SaveDeltaWizard] Allow to override existing file and suggest containing reso...
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-08-27 05:20 EDT by Tatiana Fesenko CLA
Modified: 2011-05-15 03:20 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch for "Allow to override existing resources" (1.12 KB, patch)
2010-08-27 05:22 EDT, Tatiana Fesenko CLA 		cedric.brun: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatiana Fesenko CLA 2010-08-27 05:20:19 EDT 
Helios release: I suggest the following improvements in "Save as EMFDiff" action
1)Allow to override existing file
Now it's not possible. This forces the user to either have plenty of obsolete diff files or to spend time on deleting them. Allowing to overrinde already existing diff file will solve this problem. To inform the user that the file already exists and will be overriden a warning message will be shown.

2)Suggest containing resource
"Save as EMFDiff" action is enabled only for platform resources, it's disabled if one or more files in located in local history or in the repository. Thus, it natural to suggest a containing resource of the first compared file to be a containing resource for EMFDiff.
Comment 1 Tatiana Fesenko CLA 2010-08-27 05:22:10 EDT 
Created attachment 177596 [details]
Proposed patch for "Allow to override existing resources"
Comment 2 Tatiana Fesenko CLA 2010-08-27 05:25:29 EDT 
For "containing resource" features changes should be done in SaveDeltaWizard#init() method. 
Now it passes empty selection:
   super.init(workbench, new StructuredSelection());
If we pass IResource for the first compared file in the selection it will solve the problem
Comment 3 Laurent Goubet CLA 2011-05-03 08:50:21 EDT 
Sorry for the overly long delay on this ... I commited this patch and it will be available in RC1.