Bug 32338 - Auto generated comments of quickfix method generation for unnamed package class is wrong
Summary: Auto generated comments of quickfix method generation for unnamed package cla...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-20 06:14 EST by leeder CLA
Modified: 2003-02-25 07:26 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description leeder CLA 2003-02-20 06:14:46 EST
Base is an interface in the unnamed package:

public interface Base
{
    /**
     * This is a method
     */
    public abstract void other();
}

Sub is a class created without the other() method in it (generating an error). 
Then quick-fixed to add unimplemented methods.

Added code is:

/* (non-Javadoc)
     * @see .Base#other()
     */
    public void other()
    {
        // TODO Auto-generated method stub
    }

Sub2 is a class generated with method stubs for "Inherited abstract methods" 
switched on:

public class Sub2 implements Base
{

    /* (non-Javadoc)
     * @see Base#other()
     */
    public void other()
    {
        // TODO Auto-generated method stub

    }

}
 

Note the difference in the generated comments.

Eclipse version:
Version: 2.1
Build id: 200302110800

from eclipse-SDK-I20030211-win32.zip
Comment 1 Dirk Baeumer CLA 2003-02-20 08:06:27 EST
Martin, please comment
Comment 2 Martin Aeschlimann CLA 2003-02-20 08:26:34 EST
The problem is in ITypeBinding.getQualifiedName

The name returned for Base is '.Base'
Comment 3 Olivier Thomann CLA 2003-02-20 08:46:16 EST
This is trivial to fix.
Comment 4 Olivier Thomann CLA 2003-02-20 09:35:08 EST
Fixed and released in 2.1 stream.
Regression test added.
Comment 5 David Audel CLA 2003-02-25 07:26:24 EST
Verified.