Bug 322196 - [call hierarchy] Easy to forget the 'Search In' settings in the Call Hierarchy view.
Summary: [call hierarchy] Easy to forget the 'Search In' settings in the Call Hierarch...
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 00:21 EDT by Deepak Azad CLA
Modified: 2019-01-05 20:32 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2010-08-10 00:21:57 EDT
The message at the top of the call hierarchy view says something like this - ' Members calling 'abcd()' - in workspace/working set xyz (no JRE) '

There are 2 problems
a) The '(no JRE)' part is present if in the 'Search In' settings the user has excluded JRE libraries. But there is no indication of other 'Search In' settings in the view and the user can easily forget what he had set. 
b) If you get a number of results it gets difficult for the user to figure out where a match was found. I am assuming matches in source files are considered more important than others, but it is always good to see matches in other places as well (at least I work this way).

Search view does not have the second problem as the search results are grouped by project. And you anyway cannot specify 'Search In' options in the view after doing a search. You can do that only on the Java Search page. Hence I think the Search view is ok.

Possible solutions
for a) Improve the label at the top of Call Hierarchy view - if we add more text it might get too wordy. Maybe we can use icons for each 'Search In' option with a '/' overlay on locations which were not selected?
for b) The search API gives only the matches but not where(source, jre etc) they were found. I guess you could still figure that out in SearchRequestor, but I dont know how expensive/complicated that is going to be.
Comment 1 Dani Megert CLA 2010-08-10 02:32:21 EDT
>And you anyway cannot specify 'Search In' options in the view after doing a 
>search.
Which makes it much harder in the Search view to find out the used settings ;-)

Anyway, any solution must be kept in sync with Search as we copied the settings area from there. See bug 153102 for the related request in Search.
Comment 2 Markus Keller CLA 2010-08-11 07:00:38 EDT
Icons are not accessible, and we cannot add icons in the history popup menu in the Search view.
Comment 3 Eclipse Genie CLA 2019-01-05 20:32:46 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.