Community
Participate
Working Groups
Build Identifier: 20100617-1415 For GMF-Editors it would be useful to have a way to modify position and size of Shapes in the ShapeColorsAndFontsPropertySection. This would easily allow us to make our Shapes a certain size or position them Reproducible: Always
Is there any news on this problem? Or could someone provide some hints on how to implement this? If so maybe we could do some implementation and propose a patch...
Hi Johannes, You can use org.eclipse.gmf.runtime.diagram.ui.commands.SetBoundsCommand. I see the feature with textFields for size and position and an apply button. All of this in a Group. Don't hesitate if you want more help. Regards,
Created attachment 195504 [details] Extension for PropertySection regarding Bounds We've implemented a solution to this by adding a "Bounds" section to the ColoursAndFontsPropertySection. For us this is working with various GMF editors
Thanks Johannes, I just tried this patch on our Eclipse-RPC-Modeling-Application and it is working fine. When will this patch be in the binary gmf-plugin-files? Can this make it into indigo?
Hi, it will not be possible to add it into Indigo because feature freeze happened with M7 which was released on the 04/29/2011. Need to plan it for the next version of GMF-Runtime 1.6. Who knows how to add a version number for Target milestone? Regards,
Just tested this patch again on indigo, it still works. Can we have this checked into the next release? Can we have this in Root_R1_5_maintenance? Regards, Johannes
Hi, Can you provide some tests please? Regards,
Hi, what do you mean with tests? To test this, just apply the patch and fire up any GMF-based editor. afterwards when selecting an editpart the propertysection-page should provide infos on the current bounds (size and position) of the editpart. This should also work when selecting multiple elements. Regards, Johannes
Hi, I mean some tests that select one and sevral editparts and change the bounds via the propertysection and page and then check that the ediparts have the correct new size. And effectively, we will run already existing tests to check that there are no regression. regards, (In reply to comment #8) > Hi, > > what do you mean with tests? To test this, just apply the patch and fire up any > GMF-based editor. afterwards when selecting an editpart the > propertysection-page should provide infos on the current bounds (size and > position) of the editpart. This should also work when selecting multiple > elements. > > > Regards, > Johannes
Sorry, I'm still not sure on how to provide those tests. I did those tests of cause when initially creating the patch, as we already included the patch in our RCP-Application. Is this integrated into some prebuilt org.eclipse.gmf.runtime.diagram.ui.properties or is this somewhere in CVS/SVN where I should pull it from again to test with our app? Or are you thinking about some unit-tests? This would be difficult of cause since it's an UI-thing... Regards, Johannes (In reply to comment #9) > Hi, > > I mean some tests that select one and sevral editparts and change the bounds > via the propertysection and page and then check that the ediparts have the > correct new size. > And effectively, we will run already existing tests to check that there are no > regression. >
Hi, is there any news on this issue? This is not in Kepler as well. What must I do to get this into one of the next releases? This is really a small change but quite important for our users. Regards, Johannes
the bug is fixed by adding the patch to the current version of eclipse. regards
This is still working with 4.4 SR1. Is there no way to bring this into upstream-eclipse?
