Bug 321739 - Keybinding conflicts
Summary: Keybinding conflicts
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 331293 338509 342293 342375 346680 347582 354964 356765 357235 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-04 11:01 EDT by Chris Aniszczyk CLA
Modified: 2014-11-22 15:01 EST (History)
17 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2010-08-04 11:01:21 EDT 
We currently have some keybinding conflicts. They need to be scoped properly...

!SUBENTRY 1 org.eclipse.jface 2 0 2010-08-04 09:47:48.105
!MESSAGE A conflict occurred for ALT+COMMAND+C:
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Commit,&Commit...,
		,
		Category(org.eclipse.core.commands.categories.autogenerated,Uncategorized,Commands that were either auto-generated or have no category,true),
		org.eclipse.egit.ui.internal.actions.CommitActionHandler,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.modify.method.parameters,Change Method Signature,
		Change method signature includes parameter names and parameter order,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
!SUBENTRY 1 org.eclipse.jface 2 0 2010-08-04 09:47:48.106
!MESSAGE A conflict occurred for ALT+COMMAND+M:
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.egit.ui.RepositoriesViewMerge,Merge...,
		,
		Category(org.eclipse.core.commands.categories.autogenerated,Uncategorized,Commands that were either auto-generated or have no category,true),
		org.eclipse.egit.ui.internal.repository.tree.command.MergeCommand,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.extract.method,Extract Method,
		Extract a set of statements or an expression into a new method and use the new method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
!SUBENTRY 1 org.eclipse.jface 2 0 2010-08-04 09:47:48.106
!MESSAGE A conflict occurred for ALT+COMMAND+I:
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Ignore,&Ignore,
		,
		Category(org.eclipse.core.commands.categories.autogenerated,Uncategorized,Commands that were either auto-generated or have no category,true),
		org.eclipse.egit.ui.internal.actions.IgnoreActionHandler,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.inline,Inline,
		Inline a constant, local variable or method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
Comment 1 Bernhard Merkle CLA 2010-11-09 19:33:08 EST 
I have a similar problem:
if SVN and git providers are installed at the same time (a common use case here), I get keybindings errors also

This should not happen as most of the time only ONE provider can be active for a certain project, I think
Comment 2 Matthias Sohn CLA 2010-11-30 17:15:14 EST 
*** Bug 331293 has been marked as a duplicate of this bug. ***
Comment 3 Miles Parker CLA 2010-11-30 17:33:44 EST 
Sorry I missed this dup.

I was more than half serious when in other bug I suggest that it was JDT that should be reducing their scope instead. :)  I have a similar bug 321585. Should they really be defining the key bindings for all windows?
Comment 4 Matthias Sohn CLA 2011-03-02 05:22:45 EST 
*** Bug 338509 has been marked as a duplicate of this bug. ***
Comment 5 Marc Philipp CLA 2011-03-26 17:22:04 EDT 
This problem is really annoying when using EGit and JDT on a Mac. While all three commands result in a pop-up that would let you choose, a cryptic sign has already been inserted into the source editor at that time. Therefore, it becomes very hard to use EGit and JDT at the same time because you cannot use important refactoring shortcuts any longer.

Please consider using different shortcuts for EGit.
Comment 6 Matthias Sohn CLA 2011-04-19 07:14:56 EDT 
*** Bug 342293 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Sohn CLA 2011-06-28 04:28:17 EDT 
*** Bug 346680 has been marked as a duplicate of this bug. ***
Comment 8 Christian Halstrick CLA 2011-06-29 07:43:47 EDT 
*** Bug 342375 has been marked as a duplicate of this bug. ***
Comment 9 Matthias Sohn CLA 2011-07-04 07:41:32 EDT 
merged as 66d9aa2a1cb94641a51532b2bb52c409a12d7b2c
Comment 10 Matthias Sohn CLA 2011-08-18 04:38:52 EDT 
*** Bug 354964 has been marked as a duplicate of this bug. ***
Comment 11 Matthias Sohn CLA 2011-09-06 04:21:57 EDT 
*** Bug 356765 has been marked as a duplicate of this bug. ***
Comment 12 Matthias Sohn CLA 2011-09-13 12:03:56 EDT 
*** Bug 357235 has been marked as a duplicate of this bug. ***
Comment 13 Alexander Gurov CLA 2014-11-22 15:01:20 EST 
*** Bug 347582 has been marked as a duplicate of this bug. ***