Bug 3216 - Code generation should add empty line afer methods (1G83TS3)
Summary: Code generation should add empty line afer methods (1G83TS3)
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:51 EDT by Dirk Baeumer CLA
Modified: 2003-03-17 11:41 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2001-10-10 22:51:27 EDT
Add a method to a CU should also add an empty line after the method. For example adding two methods
	should result in 

	/**
	 * @see Test#run(TestResult)
	 */
	public void run(TestResult result) {
	}

	/**
	 * @see Test#countTestCases()
	 */
	public int countTestCases() {
		return 0;
	}

	Not in

	/**
	 * @see Test#run(TestResult)
	 */
	public void run(TestResult result) {
	}
	/**
	 * @see Test#countTestCases()
	 */
	public int countTestCases() {
		return 0;
	}

	This is a problem for
		add unimplemented methods
		generate getters and setters
NOTES:
MA (1/29/01 7:35:24 PM)
	Either the java model should add the new-lines itself, or give API to do it myself

EG (2/1/01 9:51:16 AM)
	or we run the code formatter. What is the recommendation from JCore?

PM (2/2/2001 2:46:25 PM)
	Running the formatter might be a little to harsh, given the layout might be changed completely when formatting.
	Silly question: why don't you simply add a method with a source ending with an empty line ?

PM (5/10/2001 7:51:03 PM)
	Related to the line separator issue.
Comment 1 DJ Houghton CLA 2001-10-23 23:51:48 EDT
PRODUCT VERSION:
	Test pass Jan 25

Comment 2 Olivier Thomann CLA 2001-12-12 17:26:35 EST
Why you don't add a empty line in the source you insert? It should not be a 
problem for you  to add a new line at the beginning and/or at the end of the 
source of the method you added.
Comment 3 Martin Aeschlimann CLA 2001-12-13 04:28:34 EST
This is how it is currenly done.
I'm fine with this solution. Ok to close.
Comment 4 Olivier Thomann CLA 2001-12-13 10:35:49 EST
Move to close.
Comment 5 Olivier Thomann CLA 2001-12-13 10:36:28 EST
Move to close according to Martin.