Bug 320911 - Not all redundant superinterface problems reported
Summary: Not all redundant superinterface problems reported
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Srikanth Sankaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 10:38 EDT by Dani Megert CLA
Modified: 2010-09-14 07:22 EDT (History)
3 users (show)

See Also:

Attachments
Patch under consideration (14.84 KB, patch)
2010-08-12 21:46 EDT, Srikanth Sankaran CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-07-26 10:38:12 EDT 
R3.6 and HEAD.

1. load 'org.eclipse.jface.text' from CVS
2. make sure ChangeRulerColumn.java is rev.1.36
3. open it in editor
==> only 1 warning:
Redundant superinterface IVerticalRulerColumn for the type ChangeRulerColumn, already defined by IRevisionRulerColumn
is reported but IVerticalRulerInfo and IVerticalRulerInfoExtension are also redundant.

NOTE: when fixing this make sure that you don't report more than one problem per implemented interface.
Comment 1 Srikanth Sankaran CLA 2010-07-26 10:41:06 EDT 
I'll investigate this.
Comment 2 Srikanth Sankaran CLA 2010-08-11 14:48:42 EDT 
Reproduced problem on this extract:

// ----------------------------8<-------------------------------------

interface IVerticalRulerColumn {}
interface IVerticalRulerInfo {}
interface IVerticalRulerInfoExtension {}
interface IChangeRulerColumn extends IVerticalRulerColumn, IVerticalRulerInfoExtension {}
interface IRevisionRulerColumn extends IVerticalRulerColumn, IVerticalRulerInfo, IVerticalRulerInfoExtension {}

public final class X implements IVerticalRulerColumn, IVerticalRulerInfo, IVerticalRulerInfoExtension, IChangeRulerColumn, IRevisionRulerColumn {}

// ----------------------------8<-------------------------------------
Comment 3 Srikanth Sankaran CLA 2010-08-12 21:46:30 EDT 
Created attachment 176516 [details]
Patch under consideration
Comment 4 Srikanth Sankaran CLA 2010-08-12 23:17:36 EDT 
All tests pass, Satyam, please review. TIA.
Comment 5 Satyam Kandula CLA 2010-08-17 10:31:19 EDT 
(In reply to comment #4)
> All tests pass, Satyam, please review. TIA.
Patch looks good to me.
Comment 6 Srikanth Sankaran CLA 2010-08-17 10:57:56 EDT 
Released in HEAD for 3.7 M2
Comment 7 Ayushman Jain CLA 2010-09-14 07:22:14 EDT 
Verified for 3.7M2 using build I20100909-1700