Bug 32034 - "Filters" dialog is ambiguous: are we including or excluding?
Summary: "Filters" dialog is ambiguous: are we including or excluding?
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-17 12:12 EST by Alex Chaffee CLA
Modified: 2003-02-27 03:41 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Chaffee CLA 2003-02-17 12:12:22 EST
In the Triangle:Filters... dialog (named "Java Element Filters" once you open 
the window), there is nothing in the dialog to indicate that the selected items 
are ones you are filtering *out*, not filtering *in*.  Since "check mark" 
commonly means "include," but in this case means "exclude," there should be a 
clear message inside the dialog box to that effect.  E.g., instead of "Select 
the filters," say, "Select the items to exclude from view".

Alternately or additionally, change the semantics of the dialog so that check 
marks in the list represent items that *will* appear.

Especially confusing are the triple-negatives like "Non-Java projects".  OK, so 
we select the non-Java projects to not appear.  Does that mean that Java 
projects will appear or not?  It makes my brain hurt to try to figure it out.

This resembles the common code smell involving double-negative booleans:  the 
conditional

if (!isNotAvailable())

is very difficult to understand compared to 

if (isAvailable())
Comment 1 Erich Gamma CLA 2003-02-25 07:51:48 EST
The description field provides you with the details about a filter.

I agree that we should improve the wording and avoid double negavties, instead 
of Non-Java projects -> Show Only Java projects.

Also the descriptions are not consistent yet (Filter... vs Hide...)
Comment 2 Erich Gamma CLA 2003-02-26 12:17:34 EST
After discussion with Dani we came to the following conclusion:

*  change the list label to: "Select the elements to exlude from the view"

*  avoid double negatives in the description

*  do not use filter in the description
Comment 3 Dani Megert CLA 2003-02-27 03:41:47 EST
Fix available in builds >= I20030227