Bug 31990 - Working copy operations should not take workspace lock
Summary: Working copy operations should not take workspace lock
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-17 05:55 EST by Jerome Lanneluc CLA
Modified: 2003-03-11 09:06 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2003-02-17 05:55:34 EST 
Build 20030214

The new working copy operations (CreateSharedWorkingCopyOperation, 
RemoveSharedWorkingCopyOperation and ReconcileWorkingCopyOperation) should be 
marked as read-only so as to not take the workspace lock when run.
Comment 1 Jerome Lanneluc CLA 2003-02-17 06:02:44 EST 
This causes deadlocks (see bug 31891)
Comment 2 Jerome Lanneluc CLA 2003-02-17 06:34:36 EST 
Marked those 3 operation read-only (isReadOnly() returns true)
Comment 3 Philipe Mulet CLA 2003-02-17 06:37:13 EST 
Dirk - the workaround you used by creating a JavaModel runnable is internally 
still taking the lock (due to platform bug 29624), indeed it has to eagerly 
states it is modifying resources, and thus check in for later resource 
modification. Since platform is planning to fix this defect by RC1, we could 
change this too.
Comment 4 Philipe Mulet CLA 2003-02-17 06:37:37 EST 
Forgot to assign
Comment 5 Philipe Mulet CLA 2003-02-17 06:37:57 EST 
Fixed
Comment 6 Jerome Lanneluc CLA 2003-02-17 06:43:30 EST 
Fixed
Comment 7 David Audel CLA 2003-03-11 09:06:23 EST 
Verified.