Bug 318698 - [api] Additional API for supported facets in IProjectFacet
Summary: [api] Additional API for supported facets in IProjectFacet
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-07-02 07:31 EDT by Kaloyan Raev CLA
Modified: 2012-01-03 14:32 EST (History)
0 users

See Also:

Attachments
patch (3.37 KB, patch)
2010-07-02 07:32 EDT, Kaloyan Raev CLA 		no flags Details | Diff
Patch v2 (3.85 KB, patch)
2010-07-02 18:49 EDT, Konstantin Komissarchik CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2010-07-02 07:31:02 EDT 
I'd like to have two more methods in the IProjectFacet API that are related to supported facets by an IRuntime: 
  - getSupportedVersions(IRuntime runtime)
  - getSortedSupportedVersions(boolean ascending, IRuntime runtime)
Comment 1 Kaloyan Raev CLA 2010-07-02 07:32:16 EDT 
Created attachment 173290 [details]
patch

Here is a patch that implements these two methods.
Comment 2 Konstantin Komissarchik CLA 2010-07-02 18:34:47 EDT 
Thanks for the patch. I like the idea of adding the proposed api.

You haven't specified, but this doesn't look like a critical adopter issue. I am targeting this to the 2.0 release as the 1.x stream will only carry bug fixes and adopter-critical enhancements.
Comment 3 Konstantin Komissarchik CLA 2010-07-02 18:37:17 EDT 
There has been some work in 2.0 stream that affects the exact structure of the proposed API. See Bug 318765. Will attach a modified patch.
Comment 4 Konstantin Komissarchik CLA 2010-07-02 18:49:24 EDT 
Created attachment 173333 [details]
Patch v2

This patch ports the original patch to the 2.0 code line and adjusts it for API changes in that code line.
Comment 5 Konstantin Komissarchik CLA 2010-07-02 18:50:56 EDT 
Patch released.
Comment 6 Kaloyan Raev CLA 2010-07-06 02:57:15 EDT 
(In reply to comment #2)
> Thanks for the patch. I like the idea of adding the proposed api.
> 
> You haven't specified, but this doesn't look like a critical adopter issue. I
> am targeting this to the 2.0 release as the 1.x stream will only carry bug
> fixes and adopter-critical enhancements.

Not a critical at all. I just found myself using such logic in our adopter's code and thought it may be a good idea to have it in the API. 

Thanks for releasing the patch.