Bug 318063 - [API] [cdt.managedbuilder.core] RFE: Request ProjectCreatedActions class remove @noinstantiate restriction
Summary: [API] [cdt.managedbuilder.core] RFE: Request ProjectCreatedActions class remo...
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build-managed (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on: 336377
Blocks: 314342
  Show dependency tree
 
Reported: 2010-06-25 19:32 EDT by Jeff Johnston CLA
Modified: 2020-09-04 15:19 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Johnston CLA 2010-06-25 19:32:20 EDT
The Autotools project uses ProjectCreatedActions to create a new Autotools project from the New C Project wizard.  The class is public but has been marked noinstatiate which means that an API violation has occurred.  The NewAutotoolsProject code which uses the class is based on the CDT NewManagedProject code.

If there is no particular reason for the @noinstantiate, this is a request to remove the restriction or to provide a suitable API-compliant alternative.
Comment 1 Andrew Gvozdev CLA 2010-09-24 16:47:55 EDT
I took a look at ProjectCreatedActions and I do not think it is sufficiently well defined to deserve to be an API. I think there should be a set of well defined methods to create managed build project in cdt.managedbuilder.core and it should be used by the wizards CDTCommonProjectWizard etc. and by template engine processes including NewAutotoolsProject. I took a shot to define one but CDTCommonProjectWizard much resists to any API so more time investment is necessary. 

So I think for now @noinstantiate should stay until the better API is developed. That is a signal that it is not a stable interface. You still can use it in your product. You can suppress the warning or disregard it. What I can do is to add as a comment a reference to this bug, so the developers would be more cautious not to change the interface.
Comment 2 Andrew Gvozdev CLA 2010-09-29 16:12:42 EDT
Returning to the pool.
Comment 4 Andrew Gvozdev CLA 2011-02-04 13:08:17 EST
(In reply to comment #1)
> I took a look at ProjectCreatedActions and I do not think it is sufficiently
> well defined to deserve to be an API. I think there should be a set of well
> defined methods to create managed build project in cdt.managedbuilder.core and
> it should be used by the wizards CDTCommonProjectWizard etc. and by template
> engine processes including NewAutotoolsProject.
It should be probably along the lines of bug 336377.