Bug 318010 - [preferences] Add options for new FORMATTER_INSERT_NEW_LINE_AFTER_ANNOTATION_ON_* constants
Summary: [preferences] Add options for new FORMATTER_INSERT_NEW_LINE_AFTER_ANNOTATION_...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 308000 324987
Blocks:
  Show dependency tree
 
Reported: 2010-06-25 11:42 EDT by Frederic Fusier CLA
Modified: 2010-09-14 15:40 EDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (5.61 KB, patch)
2010-06-25 12:38 EDT, Frederic Fusier CLA
no flags Details | Diff
Fix (10.99 KB, patch)
2010-09-10 12:52 EDT, Markus Keller CLA
no flags Details | Diff
Proposed fix (1.11 KB, patch)
2010-09-14 15:38 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2010-06-25 11:42:51 EDT
HEAD

Add options for new FORMATTER_INSERT_NEW_LINE_AFTER_ANNOTATION_ON_* constants (bug 308000) in the UI.
Comment 1 Frederic Fusier CLA 2010-06-25 12:38:00 EDT
Created attachment 172781 [details]
Proposed patch

This patch applies on top of patch for bug 308000:
https://bugs.eclipse.org/bugs/attachment.cgi?id=172780
Comment 2 Markus Keller CLA 2010-06-29 13:37:41 EDT
See bug 308000 comment 7.
Comment 3 Markus Keller CLA 2010-09-10 12:52:28 EDT
Created attachment 178634 [details]
Fix

Released to HEAD.
Comment 4 Markus Keller CLA 2010-09-10 12:54:25 EDT
.
Comment 5 Raksha Vasisht CLA 2010-09-14 09:07:37 EDT
Verified for 3.7 M2 with I20100913-1800.
Comment 6 Rajesh CLA 2010-09-14 15:17:22 EDT
Verified in I20100914-0100.
Comment 7 Olivier Thomann CLA 2010-09-14 15:37:46 EDT
I would expect the preview to show an example that contains field and type annotations.
Comment 8 Olivier Thomann CLA 2010-09-14 15:38:08 EDT
Created attachment 178868 [details]
Proposed fix
Comment 9 Olivier Thomann CLA 2010-09-14 15:40:16 EDT
(In reply to comment #8)
> Created an attachment (id=178868) [details]
> Proposed fix
This should belong in bug 325221