Bug 317711 - Composite task doesn't check <add> elements directly
Summary: Composite task doesn't check <add> elements directly
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-06-23 11:04 EDT by Andrew Niefer CLA
Modified: 2010-06-25 10:04 EDT (History)
2 users (show)

See Also:


Attachments
patch (4.29 KB, patch)
2010-06-23 14:28 EDT, Andrew Niefer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2010-06-23 11:04:03 EDT
The composite repository ant task reuses the RepositoryList class to specify children repositories.

The repository list allows specifing a nested list of repos which is supported by the composite task, but it also can just be a repository itself instead of being a list, this is not supported by the task.

This is the difference between using
<p2.composite.repository location="file:/parent">
   <add location="child"/>
</p2.composite.repository>

and
<p2.composite.repository location="file:/parent">
   <add>
      <repository location="child"/>
   </add>
</p2.composite.repository>
Comment 1 Andrew Niefer CLA 2010-06-23 14:28:50 EDT
Created attachment 172540 [details]
patch
Comment 2 Andrew Niefer CLA 2010-06-23 14:29:39 EDT
fixed with attached patch
Comment 3 Pascal Rapicault CLA 2010-06-24 23:25:51 EDT
Do we want to port that to 3.6.1?
Comment 4 Andrew Niefer CLA 2010-06-25 10:04:21 EDT
We could release this to 3.6.1.  It is really a polish item.