Bug 317424 - [General]Bind the org.eclipse.ui. keybindings and the shortcut written in the menus
Summary: [General]Bind the org.eclipse.ui. keybindings and the shortcut written in the...
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Vincent Lorenzo CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan, usability
Depends on: 323618 324274 336906
Blocks:
  Show dependency tree
 
Reported: 2010-06-21 07:59 EDT by Vincent Lorenzo CLA
Modified: 2013-03-13 06:52 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2010-06-21 07:59:50 EDT 
Currently the shortcuts written in the menu are not linked with the shortcuts defined by in org.eclipse.ui.binding. 
It's just a setText("\t myShortcut") after the action name.
It should be interesting to link them. Moreover, if the user redefines these shortcuts, this change should appear next the corresponding action.
This problem concerns the following actions : 
	- Align Left, Right, Top, Bottom
	- Route by left, right, top, bottom
	- Delete from model (maybe)
	- other actions?
Comment 1 Vincent Lorenzo CLA 2010-07-13 10:05:05 EDT 
Delete From Diagram, with DEL, but there is a conflict in Eclipse with this shortcut.
Comment 2 Vincent Lorenzo CLA 2010-07-23 11:09:15 EDT 
Done for Delete From Model in r2468
Comment 3 Vincent Lorenzo CLA 2010-07-28 09:15:57 EDT 
With the KeyBinding for the Delete Action, we can't remove selected elements in the Model Explorer with the DEL key.
Comment 4 Vincent Lorenzo CLA 2010-08-30 10:39:17 EDT 
I posted a bug for the GMF Developpers (bug 323618), but currently we don't have answer.
A second solution to do the keybinding is to rewrite the GMF actions in our own menu, using the Eclipse API (org.eclipse.commands.ui, and so on).
With this solution, we need to rewrite the Menu Diagram, the GMF Toolbar action and the GMF popup actions.
Comment 5 Vincent Lorenzo CLA 2010-08-30 11:51:32 EDT 
Committed in r2626 (first part): 
a Papyrus Menu Diagram, 

in the popup : 
	a Papyrus Menu Filters 
	a Papyrus Menu Format
	
a Papyrus Toolbar
Comment 6 Vincent Lorenzo CLA 2010-08-31 03:00:05 EDT 
Minor Changes in r2628
Comment 7 Vincent Lorenzo CLA 2010-09-02 04:48:41 EDT 
The follow of the rewriting GMF Action is in sub task 324274.
Comment 8 Vincent Lorenzo CLA 2010-11-19 03:21:13 EST 
Note : the class org.eclipse.gmf.runtime.diagram.ui.parts.DiagramEditor adds some binding :
- DEL
- BS
- F2
- -  (zoom -)
-= (zoom =)
-+ (zoom 0)
Comment 9 Vincent Lorenzo CLA 2011-02-11 04:00:57 EST 
In R3998 : all GMF key binding are removed : 
Remove the keybindings provided by GMF :
   in the class UmlGmfDiagramEditors
   + in the class SymlDiagramEditor which doesn't have the same hierarchy that others diagrams
   
Provides a handler for the rename action (with the command org.eclipse.ui.edit.rename)

Write the keybinding for the rewritten command (Zoom In, Zoom Out) 
Other GMF bindings are removed (BS, INSERT).
Comment 10 Vincent Lorenzo CLA 2013-03-13 06:52:32 EDT 
This bug can be marked as closed fixed.