Bug 317173 - Cleanup warnings for DSF-GDB
Summary: Cleanup warnings for DSF-GDB
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 09:27 EDT by Marc Khouzam CLA
Modified: 2020-09-04 15:16 EDT (History)
3 users (show)

See Also:

Attachments
Add missing @Override for Java 6 in dsf.gdb (96.06 KB, patch)
2011-12-23 16:01 EST, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Add missing @Override for Java 6 in dsf.gdb.ui (69.18 KB, patch)
2011-12-23 16:01 EST, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
More missing @Override for Java 6 (41.71 KB, patch)
2012-01-03 21:58 EST, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Add friends for internal packages (4.72 KB, patch)
2012-04-20 15:40 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2010-06-17 09:27:20 EDT 
We should make our DSF-GDB plugins warning free.
Once we achieve that, we should make the plugin have the option to make warnings show as errors.
Comment 1 John Cortell CLA 2010-06-18 12:40:12 EDT 
I've added instructions to our WIKI on how to make a project warning-intolerant.

http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings
Comment 2 Marc Khouzam CLA 2011-12-23 16:01:02 EST 
Created attachment 208787 [details]
Add missing @Override for Java 6 in dsf.gdb

Now that we are using Java 6, there is a warning when a implemented interface method does not have the @Override annotation.

This patch fixes them for dsf.gdb

Committed to master
Comment 3 Marc Khouzam CLA 2011-12-23 16:01:50 EST 
Created attachment 208788 [details]
Add missing @Override for Java 6 in dsf.gdb.ui

And this patch is for the missing @Override for dsf.gdb.ui

Committed to master
Comment 4 Marc Khouzam CLA 2012-01-03 21:58:41 EST 
Created attachment 208976 [details]
More missing @Override for Java 6

Committed to master.
Comment 5 Marc Khouzam CLA 2012-04-20 15:40:03 EDT 
Created attachment 214324 [details]
Add friends for internal packages

Some of the CDT internal stuff was not explicitly allowing other CDT code to use it as a x-friend.  This patch add the ones for DSF/DSF-GDB.

I will commit this to master right away as it is a minor fix.
Comment 6 Marc Khouzam CLA 2012-04-20 15:54:21 EDT 
(In reply to comment #5)
> Created attachment 214324 [details]
> Add friends for internal packages
> 
> Some of the CDT internal stuff was not explicitly allowing other CDT code to
> use it as a x-friend.  This patch add the ones for DSF/DSF-GDB.
> 
> I will commit this to master right away as it is a minor fix.

Mikhail, 

this fix was in response to your comment about the "Discouraged access" warnings for the internal Tracepoint code.  I fixed all "Discouraged access" warnings for DSF/DSF-GDB with this fix.
Comment 7 Marc Khouzam CLA 2012-05-11 10:15:27 EDT 
I pushed a small cleanup to remove some @SupressWarnings and instead properly fixed the warnings.
https://git.eclipse.org/r/5945
I'll commit to master.
Comment 8 John Cortell CLA 2012-05-11 14:57:07 EDT 
(In reply to comment #7)
> I pushed a small cleanup to remove some @SupressWarnings and instead properly
> fixed the warnings.
> https://git.eclipse.org/r/5945
> I'll commit to master.

Marc, a FYI. You can configure a PDE project so that warnings won't creep back in (by forcing the warnings to be reported as errors). I set up various CDT projects this way. 

I documented the steps on the CDT wiki a while back:
http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings
Comment 9 Marc Khouzam CLA 2012-05-11 15:05:51 EDT 
(In reply to comment #8)

> Marc, a FYI. You can configure a PDE project so that warnings won't creep back
> in (by forcing the warnings to be reported as errors). I set up various CDT
> projects this way. 
> 
> I documented the steps on the CDT wiki a while back:
> http://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings

I've been aiming for this for a while, but I haven't fixed all warnings of the DSF/DSF-GDB plugins yet.  Maybe soon after Juno.  And then I'll do what you recommend.
Comment 10 CDT Genie CLA 2013-02-27 11:40:34 EST 
*** cdt git genie on behalf of Marc Khouzam ***

    Bug 317173: Cleanup warnings for DSF-GDB.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6abf9e1a4231252f06587bb0f2de002057e293ad
Comment 11 Eclipse Genie CLA 2015-06-11 09:14:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/50010
Comment 13 Eclipse Genie CLA 2015-06-11 10:55:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/50025
Comment 15 Eclipse Genie CLA 2015-06-12 16:05:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/50136