Bug 316814 - [plan] [refactoring] Pull-out refactoring doesn't detect or handle correctly the ITD case
Summary: [plan] [refactoring] Pull-out refactoring doesn't detect or handle correctly ...
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1.1   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 277055
  Show dependency tree
 
Reported: 2010-06-14 15:32 EDT by Kris De Volder CLA
Modified: 2010-07-27 13:20 EDT (History)
1 user (show)

See Also:

Attachments
Patch implementing support for pulling ITDs from one aspect to another (19.48 KB, patch)
2010-07-26 19:42 EDT, Kris De Volder CLA 		andrew.eisenberg: iplog+
Details | Diff
mylyn/context/zip (502.46 KB, application/octet-stream)
2010-07-26 19:42 EDT, Kris De Volder CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris De Volder CLA 2010-06-14 15:32:20 EDT 
Build Identifier: 

When we select an ITD in an aspect as the target of a pull-out refactoring, then it does not recognize this as a special case. As a result the refactoring proceeds without any warning, but produces code that has compile errors.

Correctly handling this case would mean at the very least issuing an error message.

Better yet would be to simply move the ITD in a way that doesn't cause compile errors.

Reproducible: Always
Comment 1 Kris De Volder CLA 2010-07-26 19:42:18 EDT 
Created attachment 175284 [details]
Patch implementing support for pulling ITDs from one aspect to another
Comment 2 Kris De Volder CLA 2010-07-26 19:42:22 EDT 
Created attachment 175285 [details]
mylyn/context/zip
Comment 3 Andrew Eisenberg CLA 2010-07-27 13:20:01 EDT 
patch applied and committed.
Comment 4 Andrew Eisenberg CLA 2010-07-27 13:20:25 EDT 
fixed.