Bug 316725 - bundles missing about.html files
Summary: bundles missing about.html files
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Main (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 316720
  Show dependency tree
 
Reported: 2010-06-14 03:52 EDT by Gregoire Dupe CLA
Modified: 2010-10-04 13:38 EDT (History)
7 users (show)

See Also:
nicolas.bros: helios+
frederic.jouault: pmc_approved+
Kenn.Hussey: pmc_approved+
Ed.Merks: pmc_approved+
nicolas.bros: pmc_approved? (sven.efftinge)
gdupe: review+
fabien.giquel: review+

Attachments
patch (284.28 KB, patch)
2010-06-15 05:39 EDT, Nicolas Bros CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2010-06-14 03:52:44 EDT 
No  about.html in org.eclipse.gmt.modisco.doc.source_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.infra.browser.uicore.examples.cnf.source_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.infra.browser.uicore.examples.cnf_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.infra.browser.uicore.source_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.infra.browser.uicore_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.java.discoverer.cdo.source_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.java.discoverer.cdo_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.java.doc.source_0.8.0.v201006090939.jar
No  about.html in
org.eclipse.gmt.modisco.xml.doc.source_0.8.0.v201006090939.jar
Comment 1 Nicolas Bros CLA 2010-06-14 05:54:43 EDT 
Fixed on trunk, but leaving open for SR1.
Comment 2 Nicolas Bros CLA 2010-06-15 05:09:21 EDT 
Wayne Beaton wants it fixed before the release (see cross-project-issues-dev). So, re-targeting for 0.8.0
Comment 3 Nicolas Bros CLA 2010-06-15 05:39:28 EDT 
Created attachment 171908 [details]
patch
Comment 4 Fabien Giquel CLA 2010-06-15 06:12:43 EDT 
Nicolas,

it seems that the features must not include about.hmtl (cf http://www.eclipse.org/legal/guidetolegaldoc.php)
I think the patch should only contain the about.html fix and not the 316723 fixes. 
David Williams explained SUA fix is not waited in 316720 https://bugs.eclipse.org/bugs/show_bug.cgi?id=316720#c0
Comment 5 Fabien Giquel CLA 2010-06-15 06:35:41 EDT 
ok, about the features, i understand now that about.html were included in "sourceTemplateFeature" subfolder. Do not take in account my last comment.
Comment 6 Gregoire Dupe CLA 2010-06-15 06:40:11 EDT 
Ok,

Please note that this bug also fixes the bug 316723.

Regards,
Grégoire
Comment 7 Nicolas Bros CLA 2010-06-15 09:33:04 EDT 
fixed on branch 0_8_0 too
Comment 8 Hugo Bruneliere CLA 2010-10-04 13:38:51 EDT 
The patch has been successfully applied.