Bug 316640 - Source form strings externalized incorrectly in RC4
Summary: Source form strings externalized incorrectly in RC4
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Problems View & Error Markers (show other bugs)
Version: 6.0   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: 6.0   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 14:19 EDT by Jeffrey Overbey CLA
Modified: 2011-05-14 06:49 EDT (History)
1 user (show)

See Also:


Attachments
Source Forms property page (RC4 screenshot) (72.25 KB, image/png)
2010-06-11 14:22 EDT, Jeffrey Overbey CLA
no flags Details
Outline view (RC4 screenshot) (7.31 KB, image/png)
2010-06-11 14:23 EDT, Jeffrey Overbey CLA
no flags Details
Patch (1.48 KB, patch)
2010-06-11 14:23 EDT, Jeffrey Overbey CLA
g.watson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Overbey CLA 2010-06-11 14:19:17 EDT
Three strings for the various Fortran source forms were externalized to bundle.properties, but they are being looked for in plugin.properties instead (and are not found).  This problem affects 6.0 RC4.  This means that the Outline view and the Source Forms property page display incorrectly.  See attached screenshots.

This is a serious regression because

* every user will see this bug.  It is apparent every time the Outline view is open and every time the Source Forms property page is opened.

* Source Form properties must be set for every Photran project, including projects upgrading from Photran 5, so the Source Forms property page is critical for the 6.0 release.

* the externalized names that are displayed instead (%source-form.name.1, %source-form.name.2) do not adequately describe the intent.  This is a very serious usability problem.

The fix is technically very simple (move the externalized strings into plugin.properties) and should have no impact on other projects in the Helios train.

As for why this bug was not discovered until now, (1) those strings were externalized just prior to RC4 (not having them externalized was a bug in itself), and (2) this bug only appeared in the RC4 build; the externalized strings work correctly in the runtime workspace, for reasons I don't completely understand.
Comment 1 Jeffrey Overbey CLA 2010-06-11 14:22:57 EDT
Created attachment 171758 [details]
Source Forms property page (RC4 screenshot)
Comment 2 Jeffrey Overbey CLA 2010-06-11 14:23:12 EDT
Created attachment 171759 [details]
Outline view (RC4 screenshot)
Comment 3 Jeffrey Overbey CLA 2010-06-11 14:23:27 EDT
Created attachment 171760 [details]
Patch
Comment 4 Jeffrey Overbey CLA 2010-06-12 12:28:18 EDT
This is fixed in CVS and was in yesterday's post-RC4 Helios build (PTP RC4a) which is now in staging.