Bug 315872 - No diagnosis of missing </br>
Summary: No diagnosis of missing </br>
Status: RESOLVED WORKSFORME
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: wst.html CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2010-06-05 05:15 EDT by Ed Willink CLA
Modified: 2011-04-15 10:41 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2010-06-05 05:15:01 EDT
RC2. The Web Page Editor does not diagnose a missing </br> although the Help installer requires it.
Comment 1 Nitin Dahyabhai CLA 2010-06-06 06:16:11 EDT
Could you provide some more details--an example or more complete scenario, as well as which version you're using?
Comment 2 Ed Willink CLA 2010-06-06 13:34:14 EDT
I was using an HTML editor (1st Page) for /org.eclipse.ocl.doc/tutorials/oclinecore/oclInEcoreTutorial.htm and committed revusion 1.1

Oops build failed; DOC not indexable; < not allowed.

So I looked for better tooling and found the Web Page Editor.

Nice yellow markers for < and > and <p> without </p> etc. (could be more visible with JDT-style LHS warning markers too, but at least they're there.)

Committed revision 1.5 trusting the Web Page editor to warn about trouble.

No; build fails, because revision 1.5 has a couple of HTML <br> without </br>.
Comment 3 Nick Sandonato CLA 2010-06-07 10:56:54 EDT
Hi.

Is the document XHTML or HTML?

HTML allows a <br> without a closing </br>, while XHTML does not allow it.

I've tried some simple examples, and when it's XHTML (<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">), I get the appropriate warnings. Saving the file generates the problem markers in the vertical ruler on the left.
Comment 4 Nick Sandonato CLA 2011-04-15 10:27:49 EDT
As far as I can tell, this sounds like a difference between HTML and XHTML.
Comment 5 Ed Willink CLA 2011-04-15 10:41:11 EDT
(In reply to comment #4)
> As far as I can tell, this sounds like a difference between HTML and XHTML.

Sorry missed the earlier comment.

I was indeed editing an HTML document.

I guess the problem is the Help installer not diagnosing HTML whrn XHTML required.