315811 – JAXB Class Generation wizard: help icon doesn't work

Bug 315811 - JAXB Class Generation wizard: help icon doesn't work

Summary: JAXB Class Generation wizard: help icon doesn't work

Status:	VERIFIED FIXED

Alias:	None

Product:	Dali JPA Tools
Classification:	WebTools
Component:	JAXB (show other bugs)
Version:	unspecified
Hardware:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	2.3 RC4
Assignee:	Neil Hauge
QA Contact:

URL:
Whiteboard:	pmc_approved
Keywords:	PII

Depends on:
Blocks:

Reported:	2010-06-04 14:00 EDT by Andrew Fernandez
Modified:	2010-09-29 12:19 EDT (History)
CC List:	5 users (show)

See Also:

Flags:	david_williams: pmc_approved+ tranle1: pmc_approved? neil.hauge: pmc_approved? (naci.dai) neil.hauge: pmc_approved? (deboer) neil.hauge: pmc_approved+ neil.hauge: pmc_approved+ neil.hauge: review+

Attachments
updated dali help jar (804.29 KB, application/octet-stream) 2010-06-04 15:30 EDT, Rick Sapir	no flags	Details
changed files only (51.83 KB, application/x-zip-compressed) 2010-06-04 16:32 EDT, Rick Sapir	no flags	Details
Additional doc contents (58.38 KB, patch) 2010-06-07 17:12 EDT, Neil Hauge	no flags	Details \| Diff
code changes (5.33 KB, patch) 2010-06-07 17:12 EDT, Neil Hauge	no flags	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Fernandez

2010-06-04 14:00:59 EDT

Build Identifier: 

The JAXB Class Generation wizard needs help to open up when a user clicks the help icon.

This is needed if the wizard will supercede the OEPE JAXB wizard.

Reproducible: Always

Steps to Reproduce:
1. Launch JAXB Class Generation wizard off of XSD
2.
3.

Comment 1 Rick Sapir

2010-06-04 15:30:52 EDT

Created attachment 171155 [details]
updated dali help jar

Added missing help for jaxb schema generation wizard. 

New help ID: wizard_jaxbschema_classes

Help jar includes new tasks and reference pages.

Comment 2 Rick Sapir

2010-06-04 16:32:44 EDT

Created attachment 171172 [details]
changed files only

Comment 3 Neil Hauge

2010-06-04 17:01:49 EDT

Rick...this content is helpful for the JAXB Schema Generation wizard, but this bug is concerning the JAXB Class Generation wizard.

Comment 4 Neil Hauge

2010-06-07 17:12:05 EDT

Created attachment 171341 [details]
Additional doc contents

Comment 5 Neil Hauge

2010-06-07 17:12:38 EDT

Created attachment 171342 [details]
code changes

Comment 6 Neil Hauge

2010-06-07 17:18:54 EDT

I have attached 2 patches, 1 is the additional doc content and the other are the very minor code changes to link to the new doc contents.  These changes add Help for JAXB Class gen and JAXB Schema gen.  Both features should be included in docs for Helios.

Comment 7 Neil Hauge

2010-06-07 17:31:04 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This bug has been requested by an adopter (Oracle) and will affect adoption of functionality.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manually tested.

* Give a brief technical overview. Who has reviewed this fix? 

This is simply some additional doc content and a couple of setHelp(...) calls to link to the new content.

* What is the risk associated with this fix? 

Very low risk.

Comment 8 David Williams

2010-06-07 23:35:38 EDT

"minor code changes" ... sure, I've heard that before. :) 

I'm ok with this as long as gets in a build in time for you to revert, if some problem occurs. I'd hate to have to rebuild after RC4, for this ... basically an enhancement. Would these be better in our quick maintenance release? Up to you.

Comment 9 Neil Hauge

2010-06-08 00:09:30 EDT

I appreciate those comments and agree.  If we can get into tonight's build then we'll go ahead with it, if not it will have to wait.

Comment 10 Neil Hauge

2010-06-08 00:54:53 EDT

It looks like we've already missed the start of tonight's build.  After this build completes there will only be time for one more build, so I guess we will have to defer.

Comment 11 David Williams

2010-06-08 01:21:12 EDT

(In reply to comment #10)
> It looks like we've already missed the start of tonight's build.  After this
> build completes there will only be time for one more build, so I guess we will
> have to defer.

Well darn, I just restarted it for my own needs :( 
I can restart it again in 20 minutes or so ... if you are still up. 

Plus ... we could leak into Wednesday if absolutely necessary.

Comment 12 Tran Le

2010-06-08 01:24:20 EDT

David, I will appreciate if you can restart it in 10 minutes, I have everything committed, but not released.
Thank you very much.

Comment 13 David Williams

2010-06-08 01:29:15 EDT

ten minutes ... 1:35. will do. 

BTW, you "nullified" the PMC approvals. It is a bugzilla bug. It doesn't refresh the flags just by hitting refresh. You need to click on the bug number at the top, to get a completely accurate synchronized version ... just in case it helps in future.

Comment 14 Neil Hauge

2010-06-08 01:32:57 EDT

Thanks guys.

Comment 15 Tran Le

2010-06-08 01:33:59 EDT

Patches released, thanks.

Comment 16 Tran Le

2010-06-08 01:42:24 EDT

Not sure why my page does not refresh even though I click on the bug number at the top. Resetting pmc_approved.

Comment 17 Neil Hauge

2010-06-08 01:58:53 EDT

Doh...just remembered that the patch you are committing doesn't have the images that are a part of the doc Tran.  I have committed them to head.

Comment 18 Neil Hauge

2010-06-08 02:30:20 EDT

(In reply to comment #17)
> Doh...just remembered that the patch you are committing doesn't have the images
> that are a part of the doc Tran.  I have committed them to head.

Changes (3 png files) have been released in case there is another restart tonight, or to simply get them into the next build.

Comment 19 Neil Hauge

2010-06-08 10:52:55 EDT

Marking as fixed.  Tested in latest build and everything seems to be fine, except for the missing images which are released for the next build.

Comment 20 Neil Hauge

2010-06-08 21:34:23 EDT

Verified that the images are correctly displaying in the latest RC4 build.