Bug 315662 - Discovery plugin regressions
Summary: Discovery plugin regressions
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P1 blocker (vote)
Target Milestone: 3.2 RC4   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 15:53 EDT by Angel Vera CLA
Modified: 2017-10-11 16:33 EDT (History)
3 users (show)

See Also:
david_williams: pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kaloyan: pmc_approved+

Attachments
comparison between the old message and the new proposed message (18.27 KB, image/png)
2010-06-03 16:58 EDT, Angel Vera CLA 		no flags Details
v1.0 (2.37 KB, patch)
2010-06-03 17:04 EDT, Angel Vera CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angel Vera CLA 2010-06-03 15:53:10 EDT 
There is two regression in the current WTP RC4 driver that are blocker for the discovery plugin and for external server adapters that use this function.

The two regression are caused by:
bug# 314823 - a fix coming from the platform
bug# 315065 - a missing character to the late update of one of the server adapters site
Comment 1 Angel Vera CLA 2010-06-03 16:58:00 EDT 
Created attachment 171028 [details]
comparison between the old message and the new proposed message
Comment 2 Angel Vera CLA 2010-06-03 17:04:45 EDT 
Created attachment 171030 [details]
v1.0
Comment 3 Angel Vera CLA 2010-06-03 17:14:54 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
This is a stop-ship defect because the function for downloading additional Server adapters is broken due:
- to a missing character in the list of download sites, and
- the missing notification that a restart of the workbench is required for the changes to take effect

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
no workaround

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Manually

* Give a brief technical overview. Who has reviewed this fix? 
Reviewed: Angel Vera

Technical overview:
For the regression caused by bug 314823, 
As per the attached file in comment #1 and the comments in bug# 314823, I am proposing that we change the message for the current dialog that warns the user of the installation process before the download/install action occurs. 

For the regression cause by bug 315065,
The change is to add the missing character that was deleted during the checkin process. 

* What is the risk associated with this fix? 
Minimal for the compilation of WTP. For runtime, is of medium risk. But minimal since the manual testing succeed
Comment 4 David Williams CLA 2010-06-03 17:54:25 EDT 
I'm not sure I understand. This bug is to be fixed in 3.2, but not bug 314823? 

I can see the fix for the "one character typo" issue, but not sure of significance of message wording change. Is that "getting ready" for bug 314823? Or .... ?
Comment 5 Neil Hauge CLA 2010-06-03 18:07:51 EDT 
(In reply to comment #4)
> I'm not sure I understand. This bug is to be fixed in 3.2, but not bug 314823? 
> 
> I can see the fix for the "one character typo" issue, but not sure of
> significance of message wording change. Is that "getting ready" for bug 314823?
> Or .... ?

I think the message change is simply a safe "fix" for 3.2 RC4.  The real fix for bug 314823 would come in 3.2.1.
Comment 6 David Williams CLA 2010-06-03 18:19:36 EDT 
Ok. In the future, I think separate bugs should be entered for separate issues (or, in this case, the once character fix could have been done through a "reopen"). but close enough.
Comment 7 Angel Vera CLA 2010-06-04 08:59:10 EDT 
(In reply to comment #5)
Thanks Neil. That is exactly what the message change is a safe fix for 3.2RC4.


(In reply to comment #6)
Your comment was noted. I guess if I reopen it I would wonder if the defect had to go through PMC approval again or not.
Comment 8 Angel Vera CLA 2010-06-04 09:49:33 EDT 
Changes committed and released to HEAD
Comment 9 Eclipse Genie CLA 2017-10-11 16:33:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/108963