Bug 315269 - "constructorFunction" and "prototypeObject" attributes should not be serialized objects
Summary: "constructorFunction" and "prototypeObject" attributes should not be serializ...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 14:09 EDT by Michael Rennie CLA
Modified: 2010-07-30 00:40 EDT (History)
1 user (show)

See Also:


Attachments
fix (2.59 KB, patch)
2010-07-30 00:39 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-06-01 14:09:56 EDT
code from HEAD

consider the following evaluate response:

1971
\r\n
{
  "command":"evaluate",
  "type":"response",
  "request_seq":12,
  "seq":13,
  "running":true,
  "success":true,
  "body":{
          "evaluate":{
                      "handle":1,
                      "constructorFunction":{"ref":2},
                      "prototypeObject":{"ref":3},
                      "className":"Object",
                      "properties":[
                                    {"ref":6,"name":"line6"},
                                    ..<snip>..,
                                    {"ref":61,"name":"line1"}],
                      "type":"object"
                     }
          }
}

"constructorFunction":{"ref":2} does not need to be a serialized object, it should follow suit with other id-able items and just be "constructorFunction":2. The same change should be made for "prototypeObject":{"ref":3} -> "prototypeObject":3
Comment 1 Michael Rennie CLA 2010-07-30 00:39:01 EDT
Created attachment 175538 [details]
fix

the patch changes the two attributes to be simply numbers and not serialized objects. This increases parsing performance for ObjectReferences and decreases packet size.
Comment 2 Michael Rennie CLA 2010-07-30 00:40:01 EDT
applied patch to HEAD