Bug 314962 - Eclipse-BundleShape manifest header doesn't work.
Summary: Eclipse-BundleShape manifest header doesn't work.
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5.2   Edit
Hardware: PC Linux-GTK
: P3 normal with 5 votes (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2010-05-28 18:57 EDT by Alex Ignácio da Silva CLA
Modified: 2019-10-03 12:31 EDT (History)
6 users (show)

See Also:


Attachments
Hello world plugin based product. (56.20 KB, application/zip)
2010-06-02 15:10 EDT, Alex Ignácio da Silva CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Ignácio da Silva CLA 2010-05-28 18:57:29 EDT
Build Identifier: 20100218-1602

When exporting a plug-in based product, the plug-ins are always exported as jar files, even if they have set "Eclipse-BundleShape: dir" in their manifest files.

This is not working for other users as well, as seen in the comments of this blog post:

http://eclipsesource.com/blogs/2009/01/20/tip-eclipse-bundleshape/

Reproducible: Always

Steps to Reproduce:
I have verified this in my own project when exporting the product via the Eclipse product export wizard.
Comment 1 Andrew Niefer CLA 2010-06-01 13:49:25 EDT
"Eclipse-BundleShape: dir" works for me in a plugin based product export.

The code for this during export is in UI, CoreUtility#guessUnpack called from ProductExportOperation#setAdditionalAttributes.

I see a couple of cases where the bundle shape would not get used:
1) the projects that do not have the "org.eclipse.jdt.core.javanature" are always unpacked (not sure why)
2) bundles that exist as jars on disk (ie binary jars in the target) are not unpacked
Comment 2 Andrew Niefer CLA 2010-06-01 13:50:23 EDT
Also, Alex if you can attach a small example where this doesn't work, that would help find the problem.  And, are you checking "Generate metadata repository" during export?
Comment 3 Alex Ignácio da Silva CLA 2010-06-02 15:10:39 EDT
Created attachment 170865 [details]
Hello world plugin based product.
Comment 4 Alex Ignácio da Silva CLA 2010-06-02 15:16:14 EDT
I've attached a simple hello world RCP application with a product based on plugins.

"Eclipse-BundleShape: dir" only works if I select "Generate metadata
repository" during export. Unfortunately I can't test this workaround in my real world application because I get an error message if I check it (I'm not concerned about it right now, since I do not need to generate an update repository).
Comment 5 Marco Lopes CLA 2011-05-26 19:11:28 EDT
It does not work under Indigo Release Build id: 20110519-1049

(or at most, randomly works)
Comment 6 Matthias Striegl CLA 2011-06-20 09:16:52 EDT
It seems to work when doing some fake edit on the MANIFEST.MF file, saving it, and exporting the plugin immediately afterwards (an observed behaviour in release 3.6.2).
Comment 7 Matthias Striegl CLA 2011-06-20 09:27:45 EDT
... using the "Deployable plug-ins and fragments" export wizard here.
Comment 8 Paul Ramsden CLA 2017-03-15 02:29:56 EDT
I had 2 projects: one produced a folder as required, the other would only produce a jar in spite of the Bundle-Shape: dir entry.

The difference I noticed was the position of the directive. In the first project it was right at the end of the manifest but in the second it was near the top. I moved the directive to the end of the manifest and the project produces a folder.

(Using Kepler on Windows7)
Comment 9 Eclipse Genie CLA 2019-10-03 12:31:04 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.