Bug 314308 - Optimisations for AbstractCLaunchDelegate2
Summary: Optimisations for AbstractCLaunchDelegate2
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on: 309126
Blocks:
  Show dependency tree
 
Reported: 2010-05-25 13:00 EDT by James Blackburn CLA
Modified: 2020-09-04 15:26 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2010-05-25 13:00:53 EDT
+++ This bug was initially created as a clone of Bug #309126 +++

There are a couple things that could be tidied (see bug 309126 comment 16 points 2 & 5).

existsProblems(...) should probably just #findMaxProblemSeverity rather than fetching and checking all the markers:

protected boolean existsProblems(IProject proj) throws CoreException {
	return proj.findMaxProblemSeverity(IMarker.PROBLEM, true, IResource.DEPTH_INFINITE) >= IMarker.SEVERITY_ERROR;
}

Build before launch shouldn't use the workspace root scheduling rule. This pre-supposes that the builders require this which they may not:
  
  ResourcesPlugin.getWorkspace().run(build, null, IWorkspace.AVOID_UPDATE, monitor);