313586 – [preferences] Expose new preference in the UI

Bug 313586 - [preferences] Expose new preference in the UI

Summary: [preferences] Expose new preference in the UI

Reported:	2010-05-19 13:34 EDT by Olivier Thomann
Modified:	2010-05-21 04:04 EDT (History)
CC List:	3 users (show)

See Also:

Flags:	daniel_megert: review+ deepakazad: review+

Attachments
Proposed fix (3.55 KB, patch) 2010-05-19 13:52 EDT, Olivier Thomann	no flags	Details \| Diff
Updated patch (preview has some problems) (4.20 KB, patch) 2010-05-20 06:05 EDT, Markus Keller	no flags	Details \| Diff
Fix 3 (4.06 KB, patch) 2010-05-20 06:53 EDT, Markus Keller	no flags	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Olivier Thomann

2010-05-19 13:34:47 EDT

The UI needs to expose the new constant introduced by the fix for bug 313524.

Comment 1 Olivier Thomann

2010-05-19 13:52:51 EDT

Created attachment 169164 [details]
Proposed fix

Comment 2 Markus Keller

2010-05-20 06:05:29 EDT

Created attachment 169303 [details]
Updated patch (preview has some problems)

Comment 3 Markus Keller

2010-05-20 06:53:17 EDT

Created attachment 169308 [details]
Fix 3

Final patch for review (the previous one showed a variant of the problem from bug 59891 comment 45).

Comment 4 Dani Megert

2010-05-20 07:05:19 EDT

+1 for RC2.

Mnemonic can be added to the first 'P'.

Comment 5 Markus Keller

2010-05-20 07:12:42 EDT

Released to HEAD, but used &o as mnemonic (there's already "&Profile name:").

Comment 6 Dani Megert

2010-05-20 07:15:29 EDT

>used &o as mnemonic (there's already "&Profile name:").
Indeed - argh!

Comment 7 Deepak Azad

2010-05-20 07:49:36 EDT

+1 for RC2.

Comment 8 Dani Megert

2010-05-21 04:04:31 EDT

Verified in I20100520-1744 that the preference is there and works.