Community
Participate
Working Groups
Build Identifier: M20070212-1330 (Ubuntu version: 3.2.2-5ubuntu2) Is there a possibility for this? You may be able to automatically determine package of a Java object based on the assignment. Say you have a Java statement: Date todayDate = Calendar.getInstance().getTime(); We haven't yet added the import statement "import java.util.Date;". At this point, based on the type of the object returned by getTime(), can we determine that todayDate belongs to java.util.Date (as opposed to other Date classes like java.sql.Date) and automatically create an import statement? Reproducible: Always
Interesting idea. See also bug 87950. Code assist could provide a required import proposal along with the method proposal.
Ayush, please follow up
I wouldn't expect that content assist for getTime() automagically adds an import. What if wanted to type ...getTime().toSqlDate()? I know that java.util.Date#toSqlDate() doesn't exist, but you get the point. This should be dealt with in Organize Imports (bug 87950), or the user should just write "Calendar.getInstance().getTime();" and the use Quick Assist (Ctrl+1) to create the new variable.
>What if wanted to type ...getTime().toSqlDate()? I know that > java.util.Date#toSqlDate() doesn't exist, but you get the point. Actually, what I was thinking is that the automatic import statement only gets added if the user added ; to indicate end of line. Or if the ; already existed and user made some changes to the line then automatic import to kick in after they moved to another line. Of course, to ensure that user is not left in the dark, some unobtrusive popup having transparent background that auto-fades could show up -- perhaps towards upper-right corner or somewhere convenient. The popup would indicate that the import statement was added. The popup fades away to ensure user doesn't need to take any action. I note your point regarding bug 87950.
(In reply to comment #4) > >What if wanted to type ...getTime().toSqlDate()? I know that > > java.util.Date#toSqlDate() doesn't exist, but you get the point. > > Actually, what I was thinking is that the automatic import statement only gets > added if the user added ; to indicate end of line. Or if the ; already existed > and user made some changes to the line then automatic import to kick in after > they moved to another line. > Of course, to ensure that user is not left in the dark, some unobtrusive popup > having transparent background that auto-fades could show up -- perhaps towards > upper-right corner or somewhere convenient. The popup would indicate that the > import statement was added. The popup fades away to ensure user doesn't need > to take any action. > > I note your point regarding bug 87950. Sorry for following up late on this. To me, it doesn't sound very content-assist like to automatically add something without being prompted by a ctrl-space. If the intension is to add the import statement only after the user has typed in the ; signalling end of line, organise imports is a better way of doing that. I dont think its good to expect the user to press CTRL - SPACE after typing in the ';' and find that the import statement has been added. Also, if it anyway has to involve user action, it might as well be done via CTRL+1. The idea of using content assist doesnt sound too convincing to me. Dani, what do you think?
>Dani, what do you think? I agree, especially due to the scenario that Markus gave. Note though that content assist does insert imports in some cases, e.g. here: HashMap m; m.<code assist> ==> inserts import for HashMap. Suggest to close as WONTFIX.
(In reply to comment #6) > >Dani, what do you think? > I agree, especially due to the scenario that Markus gave. Note though that > content assist does insert imports in some cases, e.g. here: > > HashMap m; > m.<code assist> > ==> inserts import for HashMap. > > Suggest to close as WONTFIX. Closing as WONTFIX
Verified for 3.7M3.
