Community
Participate
Working Groups
Build Identifier: I20100312-1448 BidiProcessor does a Mac OS X check in the following code: > /* > * $TODO Workaround for Carbon. AWT DLL cannot start properly on carbon. > * Waiting for bug 82104 > */ > private static final boolean isMacOS = SWT.getPlatform().equals("carbon"); //$NON-NLS-1$ Not sure what the impact of this is but would seem like the Platform check is potentially wrong, given the name of the variable. Reproducible: Didn't try
Do you want to add || SWT.getPlatform().equals("cocoa")?
Created attachment 169280 [details] Patch for correct Mac OS X detection
Looks great. Committed to HEAD for RC2.
Actually, this is the cause for the failure of the draw2d test cases that are reported in bug #141105. Without the newly introduced cocoa platform check (which does not seem to be necessary), the TextFlow test cases all pass successfully on MacOSX Cocoa. While the comment in BidiProcessor refers to bug #82104, I cannot see this has something to do with AWT DLL not loading (and I cannot observe any problems if removing the check). I would thus propose to revert the change so that on Cocoa, the behavior is as expected again.
(In reply to comment #4) > Actually, this is the cause for the failure of the draw2d test cases that are > reported in bug #141105. Without the newly introduced cocoa platform check > (which does not seem to be necessary), the TextFlow test cases all pass > successfully on MacOSX Cocoa. > > While the comment in BidiProcessor refers to bug #82104, I cannot see this has > something to do with AWT DLL not loading (and I cannot observe any problems if > removing the check). I would thus propose to revert the change so that on > Cocoa, the behavior is as expected again. Following the first comment in #82104 to bug #67384 (which refers to the AWT problem being mentioned), and navigating further to its related bugs, one can infer that the problem actually is limited to MacOSX Carbon and does not occur on MacOSX Cocoa.
Reverted changes in cvs HEAD and 3.6 maintenance branch. Verified Draw2d Test cases successfully pass on MacOSX Cocoa again and that Text example is operational as well.
(In reply to comment #6) > Reverted changes in cvs HEAD and 3.6 maintenance branch. Verified Draw2d Test > cases successfully pass on MacOSX Cocoa again and that Text example is > operational as well. While reverting, renamed variable to refer to carbon alone.
