Bug 313080 - SpellCheckingTest#test() runs very fast
Summary: SpellCheckingTest#test() runs very fast
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2010-05-17 04:27 EDT by Deepak Azad CLA
Modified: 2010-05-19 09:34 EDT (History)
3 users (show)

See Also:
raksha.vasisht: review+
deepakazad: review+

Attachments
Fix (2.83 KB, patch)
2010-05-18 06:00 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2010-05-17 04:27:00 EDT 
SpellCheckingTest#test() seems to run very fast on all platforms since it was added in Jan 2010. I suspect something is wrong as this test takes about 300ms on my machine.
Comment 1 Dani Megert CLA 2010-05-18 06:00:06 EDT 
The problem is that by default spelling is disabled when the performance tests are run on the official/releng test machines, see AbstractDecoratedTextEditorPreferenceConstants, lines 551-558. This is pretty tricky because disabling doesn't happen when running the performance tests locally, hence we get different numbers. For 3.7 we should move that code into the performance tests itself (filed bug 313313 to track this).

Another problem that the new spell checking test causes is that we no longer do the OpenJavaEditorTest setup at the end of the PerformanceTestSuite.
Comment 2 Dani Megert CLA 2010-05-18 06:00:33 EDT 
Created attachment 168889 [details]
Fix
Comment 3 Deepak Azad CLA 2010-05-18 06:11:44 EDT 
+1 for RC2
Comment 4 Raksha Vasisht CLA 2010-05-18 06:22:41 EDT 
Looks good.
Comment 5 Dani Megert CLA 2010-05-18 06:31:07 EDT 
Fixed in HEAD and perf_35x.
Comment 6 Dani Megert CLA 2010-05-19 09:34:18 EDT 
Verified in I20100518-0800 that the test no longer runs in 0s.