Bug 312711 - better cflow counter/stack names
Summary: better cflow counter/stack names
Status: NEW
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Andrew Clement CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 16:38 EDT by Andrew Clement CLA
Modified: 2013-06-24 11:03 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2010-05-12 16:38:08 EDT 
The numeric suffixes attached to these fields are a bit fragile - I'd like to change them to be a hashCode of the pointcut so here:

cflow(execution(* main(..)) 

the corresponding field would be ajc$cflowCounter$NNN where NNN is the hashCode of 'execution(* main(..))'

Right now it is simply a number that represents how many other cflows are around.

If I do this, we will be moving to a mode where cflows() can share counters/stacks.  This is cool but (definetly in the case of stacks) we will have to be careful the logic to push/pop isn't duplicated - that would be a real waste.
Comment 1 Andrew Clement CLA 2013-06-24 11:03:33 EDT 
unsetting the target field which is currently set for something already released