Bug 312677 - Host OSGi console should have close action
Summary: Host OSGi console should have close action
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 312697 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-12 14:02 EDT by Darin Wright CLA
Modified: 2010-05-12 17:30 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review+

Attachments
patch (5.75 KB, patch)
2010-05-12 14:32 EDT, Darin Wright CLA 		no flags Details | Diff
udpated patch (7.22 KB, patch)
2010-05-12 15:59 EDT, Darin Wright CLA 		no flags Details | Diff
updated patch (7.08 KB, patch)
2010-05-12 16:17 EDT, Thomas Watson CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2010-05-12 14:02:45 EDT 
The Host OSGi console should have a close action/toolbar item similar to the Java stack trace console. The action should invoke the "disconnect" command.
Comment 1 Darin Wright CLA 2010-05-12 14:32:22 EDT 
Created attachment 168223 [details]
patch

Adds close button in the toolbar.
Comment 2 Darin Wright CLA 2010-05-12 14:32:53 EDT 
Please review, Curtis.
Comment 3 Thomas Watson CLA 2010-05-12 15:27:03 EDT 
Patch works for me.  Although I did find (and fix) a bug in the framework when testing this patch.  bug312691.
Comment 4 Darin Wright CLA 2010-05-12 15:59:20 EDT 
Created attachment 168245 [details]
udpated patch

This patch incorporates a fix to bug 312697. Since the two patches will collide, I have combined them.
Comment 5 Darin Wright CLA 2010-05-12 15:59:44 EDT 
*** Bug 312697 has been marked as a duplicate of this bug. ***
Comment 6 Thomas Watson CLA 2010-05-12 16:17:12 EDT 
Created attachment 168248 [details]
updated patch

in init() you should write the message before registering the console session to ensure the message is printed before the osgi> prompt.
Comment 7 Darin Wright CLA 2010-05-12 16:20:02 EDT 
(In reply to comment #6)
> Created an attachment (id=168248) [details]
> updated patch
> in init() you should write the message before registering the console session
> to ensure the message is printed before the osgi> prompt.

Makes sense. I never saw it happen, but wondered...
Comment 8 Curtis Windatt CLA 2010-05-12 17:30:02 EDT 
+1 works great now, able to close/disconnect/etc from the console and open again later.

I made one small change to close the input stream that writes out the warning message.

Fixed in HEAD.