Bug 312268 - Editors cannot display temporary source when workbench restarts
Summary: Editors cannot display temporary source when workbench restarts
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-05-10 10:31 EDT by Michael Rennie CLA
Modified: 2010-05-10 14:16 EDT (History)
1 user (show)

See Also:
simon_kaegi: review+


Attachments
screen shot (20.33 KB, image/png)
2010-05-10 10:31 EDT, Michael Rennie CLA
no flags Details
fix (3.83 KB, patch)
2010-05-10 12:47 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-05-10 10:31:23 EDT
Created attachment 167716 [details]
screen shot

code from HEAD

When source is opened by the debugger and it comes from an external or transient location, we fake it up to show a temp file from the workspace. If you shut down Eclipse with one of these editors open and restart you will see an ominous looking editor part with an error stating "Cannot open editor: file does not exist". This is because the editor is saved when you shut down, but on restart the temps source is no longer available.

We should add a hook to close any of these editors when the workbench is shutting down (or something similar to prevent these "busted editors" from showing up).

See attached screen shot
Comment 1 Michael Rennie CLA 2010-05-10 12:47:27 EDT
Created attachment 167753 [details]
fix

Patch provides a hook to close any editors that reference source from the temp location when the workbench shuts down
Comment 2 Michael Rennie CLA 2010-05-10 12:48:38 EDT
This would be a very good RC1 candidate, as seeing the error editor can be a bit of a concern.
Comment 3 Michael Rennie CLA 2010-05-10 14:16:00 EDT
applied to HEAD