Bug 312014 - content of tree view (projects and folders) to export to a jar is not read by some screen readers
Summary: content of tree view (projects and folders) to export to a jar is not read by...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2010-05-07 04:04 EDT by Sérgio Neves CLA
Modified: 2010-08-27 13:30 EDT (History)
1 user (show)

See Also:


Attachments
Fix (5.32 KB, patch)
2010-08-27 13:29 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sérgio Neves CLA 2010-05-07 04:04:16 EDT
Build Identifier: N20100505-2000

I tested it with JAWS and NVDA and they gave me the same result.
The workaround is to use the JAWS cursor to do the mapping between the project/folder names and their selected state, but it's a boring task.
There are tree views in eclipse that are well red by JAWS, such as window > customize perstective...

Reproducible: Always

Steps to Reproduce:
1. Create one or two projects to exercise this test.
2. go to file > export > java > jar file and press next.
3. You are now focused on the tree view which displays projects and folders to select.
4. Press up and down arrows.
Expected results: screen reader should say something like: "<project name|folder name> <state of tree view item (closed|opened)> <state of checkbox>"
Actual results: screen reader says: "select projects and folders to export <state of tree view item (closed|opened)> <state of checkbox>"
Comment 1 Susan McCourt CLA 2010-05-08 18:23:44 EDT
Carolyn, can you advise?  If this is a matter of the client code having to do something specific, then please punt back to us.
Comment 2 Carolyn MacLeod CLA 2010-08-25 15:26:14 EDT
Moving to JDT UI.

The problem is the following 2 lines of code in method org.eclipse.jdt.internal.ui.jarpackager.JarPackageWizardPage.createInputGroup():

SWTUtil.setAccessibilityText(fInputGroup.getTree(), JarPackagerMessages.JarPackageWizardPage_tree_accessibility_message);
SWTUtil.setAccessibilityText(fInputGroup.getTable(), JarPackagerMessages.JarPackageWizardPage_table_accessibility_message);

When the accessible name is set for the entire Table (or the entire Tree) then that is what is answered for every TableItem and TreeItem.  :)

Here is an SWT snippet that shows approximately what should be done for tables and trees in the getName method:

http://dev.eclipse.org/viewcvs/index.cgi/~checkout~/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet291.java

Please make sure that there are no other Tables, Trees, or Lists that set the accessible name for the entire control without considering the individual items.
This would hold for TabFolder, too, or any control with items, although I am sure that Table, Tree, and List are the most likely to have accessible names explicitly set.
Comment 3 Markus Keller CLA 2010-08-27 13:29:27 EDT
Created attachment 177633 [details]
Fix

Thanks for the investigation. I've fixed this problem and a similar problem I found in the warning dialog shown by refactorings. I found no other culprits in the SDK.
Comment 4 Markus Keller CLA 2010-08-27 13:30:04 EDT
Fixed in HEAD.