Bug 311917 - Update Manager doesn't allow canceling during reqs and dependencies calculation
Summary: Update Manager doesn't allow canceling during reqs and dependencies calculation
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 12:09 EDT by John Cortell CLA
Modified: 2010-05-06 18:40 EDT (History)
1 user (show)

See Also:


Attachments
screenshot (30.53 KB, image/gif)
2010-05-06 12:09 EDT, John Cortell CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-05-06 12:09:03 EDT
See attached screenshot. Notice the cancel button is disabled. For some reason, the act of calculating requirements and dependencies was taking way too long (maybe network or server problems; who knows). Anyway, I wasnted to cancel the operation and try again later, but I didn't have the option. I had to open the task manager and hard-kill the process.
Comment 1 John Cortell CLA 2010-05-06 12:09:33 EDT
Created attachment 167334 [details]
screenshot
Comment 2 Susan McCourt CLA 2010-05-06 12:40:43 EDT
The red "stop" button next to the progress bar will cancel the calculation.
Comment 3 Andrew Niefer CLA 2010-05-06 12:47:13 EDT
I think there is a separate problem with downloading these jars in the first place.  See bug 311929 and bug 311776
Comment 4 Susan McCourt CLA 2010-05-06 13:08:27 EDT
In the screenshot, the [x] contact all sites checkbox is checked, which means that all enabled sites are being loaded at this time.

Another change in M7 is that artifact repo references are followed and loaded at resolve time, whereas before they were loaded at collect time.    That's what's happening in this picture...the artifacts.jar for one of the enabled sites is being downloaded.
Comment 5 John Cortell CLA 2010-05-06 14:29:17 EDT
(In reply to comment #2)
> The red "stop" button next to the progress bar will cancel the calculation.

Indeed. I did not see the red box. User error.
Comment 6 Susan McCourt CLA 2010-05-06 14:59:14 EDT
(In reply to comment #5)
> (In reply to comment #2)
> > The red "stop" button next to the progress bar will cancel the calculation.
> 
> Indeed. I did not see the red box. User error.

In your defense, the cancel button used to work, and it was bug 287887 that introduced the red button (because many users never knew that cancel worked in this way).  So it was your muscle memory.  ;-)
Comment 7 John Cortell CLA 2010-05-06 15:07:46 EDT
(In reply to comment #6)
> In your defense, the cancel button used to work, and it was bug 287887 that
> introduced the red button (because many users never knew that cancel worked in
> this way).  So it was your muscle memory.  ;-)

Funny. Well, I think 287887 took things too far. In my case, I wanted to cancel out of the whole Update Manager operation, not just the sub-task of getting the requirement and dependencies. For that situation, the intuitive place to go is the Cancel button in the dialog. Having to cancel the sub-task and then cancel out of the dialog seems both unintuitive and onerous. I think it's good that the sub-task can now be canceled, but I think the ability to cancel out of everything (with a single click) is still desirable.
Comment 8 Susan McCourt CLA 2010-05-06 17:18:51 EDT
(In reply to comment #7)
> Funny. Well, I think 287887 took things too far. In my case, I wanted to cancel
> out of the whole Update Manager operation, not just the sub-task of getting the
> requirement and dependencies. For that situation, the intuitive place to go is
> the Cancel button in the dialog. Having to cancel the sub-task and then cancel
> out of the dialog seems both unintuitive and onerous. I think it's good that
> the sub-task can now be canceled, but I think the ability to cancel out of
> everything (with a single click) is still desirable.

Well, you never had the single click cancel, even before bug 287887.  You would have to cancel once to stop the operation, and then cancel again to get out of the wizard.  What that bug did was separate those two, because redefining the meaning of the cancel button on the fly was tripping people up.
Comment 9 John Cortell CLA 2010-05-06 17:23:22 EDT
(In reply to comment #8)
> (In reply to comment #7)
> > Funny. Well, I think 287887 took things too far. In my case, I wanted to cancel
> > out of the whole Update Manager operation, not just the sub-task of getting the
> > requirement and dependencies. For that situation, the intuitive place to go is
> > the Cancel button in the dialog. Having to cancel the sub-task and then cancel
> > out of the dialog seems both unintuitive and onerous. I think it's good that
> > the sub-task can now be canceled, but I think the ability to cancel out of
> > everything (with a single click) is still desirable.
> 
> Well, you never had the single click cancel, even before bug 287887.  You would
> have to cancel once to stop the operation, and then cancel again to get out of
> the wizard.  What that bug did was separate those two, because redefining the
> meaning of the cancel button on the fly was tripping people up.

Fair enough. I've never had to cancel out that dialog, so I wasn't sure what the previous behavior is. From what you describe, it certainly was confusing. So, I guess what I'm basically stating is a feature request. I'll open a new bugzilla for that.