Bug 311835 - [preferences] Add option for FORMATTER_USE_ON_OFF_TAGS (bug 311582)
Summary: [preferences] Add option for FORMATTER_USE_ON_OFF_TAGS (bug 311582)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 311582
Blocks:
  Show dependency tree
 
Reported: 2010-05-06 04:48 EDT by Markus Keller CLA
Modified: 2010-05-17 05:17 EDT (History)
1 user (show)

See Also:
markus.kell.r: review+

Attachments
Fix (5.93 KB, patch)
2010-05-07 09:52 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-05-06 04:48:03 EDT 
HEAD

Add option for FORMATTER_USE_ON_OFF_TAGS (bug 311582) in the UI.
Comment 1 Dani Megert CLA 2010-05-07 09:52:37 EDT 
Created attachment 167472 [details]
Fix
Comment 2 Markus Keller CLA 2010-05-10 10:30:26 EDT 
+1 for RC1 with 1 change in FormatterMessages.properties:

OffOnTagsTabPage_description=Off / on tags can be used ...

=> "on" should be written as "On", like everywhere else on the page (including the "Enable Off / On tags" checkbox).

I would also remove the spaces around the "/" (i.e. "Off/On"), but it's also OK with spaces.
Comment 3 Dani Megert CLA 2010-05-10 10:50:56 EDT 
Fixed in HEAD with changes suggested by Markus.
Comment 4 Raksha Vasisht CLA 2010-05-17 05:17:10 EDT 
Verified for 3.6RC1 with build  N20100516-2000.