310789 – Optimize the update of projects JRE container when the VM has changed

Bug 310789 - Optimize the update of projects JRE container when the VM has changed

Summary: Optimize the update of projects JRE container when the VM has changed

Status:	RESOLVED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	3.6
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.6 RC1
Assignee:	Darin Wright
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	302295
	Show dependency tree

Reported:	2010-04-28 06:18 EDT by Frederic Fusier
Modified:	2010-05-03 16:41 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	curtis.windatt.public: review+

Attachments
Draft patch implementing the requested optimization (4.20 KB, text/plain) 2010-04-28 06:18 EDT, Frederic Fusier	no flags	Details
updated patch (5.22 KB, patch) 2010-05-03 12:11 EDT, Darin Wright	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Frederic Fusier

2010-04-28 06:18:10 EDT

Created attachment 166301 [details]
Draft patch implementing the requested optimization

When a VM change is observed, all JRE Container of existing project needs to be updated and this is done through the LaunchingPLugin.VMChanges.rebind(...) method.

This method calls the JavaCore.setClasspathContainer project per project (through the JREContainerInitializer) although this method accepts an array of projects.

An interesting optimization (see bug 302295) could be to bundle the projects which need to initialize their JRE container and call the JavaCore.setClasspathContainer(...) method only once with the array of the concerned projects.

Comment 1 Darin Wright

2010-04-28 09:42:11 EDT

RC1 candidate.

Comment 2 Darin Wright

2010-05-03 12:11:04 EDT

Created attachment 166804 [details]
updated patch

Updated copyrights and fixed a bug in the original patch. The original patch was always re-binding all projects to each container, rather than the "referencedProjects".

Comment 3 Darin Wright

2010-05-03 12:13:31 EDT

please review patch, Curtis.

Comment 4 Curtis Windatt

2010-05-03 16:41:53 EDT

+1 fixed in HEAD.