Community
Participate
Working Groups
I20100425-2000. The new support to get the bundle's source from a repository is cool but hard to discover. For 3.6 we should at least add the option to the 'Import As' context menu of the Plug-ins view. If possible, we should also offer the 'Import As' context menu on elements inside the 'Plug-in Dependencies' container (in the Package Explorer). This would allow an easy conversion from binary to source.
*** Bug 312505 has been marked as a duplicate of this bug. ***
Created attachment 168415 [details] patch Adds "Import As > Repository Project..." to the import menu in the plug-ins view.
Consider for RC2
Bug 312505 is more specific and the patch would better fit into that bug. We could keep this one to address the remaining issues during 3.7: >If possible, we should also offer the 'Import As' context menu on elements >inside the 'Plug-in Dependencies' container (in the Package Explorer). This >would allow an easy conversion from binary to source. I'm +1 to fix this in RC2 but when I tried the patch I got an NPE, hence review- on the patch itself. java.lang.NullPointerException at org.eclipse.pde.internal.ui.views.plugins.ImportActionGroup.getImportDescriptions(ImportActionGroup.java:115) at org.eclipse.pde.internal.ui.views.plugins.ImportActionGroup.handleImport(ImportActionGroup.java:93) at org.eclipse.pde.internal.ui.views.plugins.ImportActionGroup.access$0(ImportActionGroup.java:81) at org.eclipse.pde.internal.ui.views.plugins.ImportActionGroup$ImportAction.run(ImportActionGroup.java:58) at org.eclipse.jface.action.Action.runWithEvent(Action.java:498) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2624)
I filed bug 313392 to track the additional enhancement request
Created attachment 168970 [details] updated patch Updated patch to address NPE.
+1 for the updated patch. It's rather large for an RC2 fix, but useful. The generic message you get when you try to import a plug-in without a scmurl manifest entry isn't very helpful. It appears there is no way for us to currently know whether the import failed because there is no source repo entry or if something else went wrong.
Verified that the NPE is gone. I would align the wording to the import wizard. &Repository Project... ==> P&roject from a Repository... +1 for RC2.
Applied/Fixed. Used suggested wording.
Verified.
