Bug 310330 - Add multiple encoding support for the batch compiler
Summary: Add multiple encoding support for the batch compiler
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 260997 (view as bug list)
Depends on:
Blocks: 260997
  Show dependency tree
 
Reported: 2010-04-23 15:12 EDT by Olivier Thomann CLA
Modified: 2010-04-27 08:18 EDT (History)
3 users (show)

See Also:

Attachments
Proposed fix (15.76 KB, patch)
2010-04-25 14:24 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix + regression tests (24.74 KB, patch)
2010-04-25 18:55 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-04-23 15:12:07 EDT 
In order to fix bug 260997, the batch compiler should be able to take multiple encoding on the command line. The last one wins.
Inside the ant task the encoding specified in the javac ant task itself should win over the ones specified inside compilerarg arguments.
Comment 1 Olivier Thomann CLA 2010-04-23 15:13:19 EDT 
I am working on a fix.
Comment 2 Olivier Thomann CLA 2010-04-25 14:24:33 EDT 
Created attachment 166022 [details]
Proposed fix
Comment 3 Olivier Thomann CLA 2010-04-25 18:55:48 EDT 
Created attachment 166033 [details]
Proposed fix + regression tests
Comment 4 Olivier Thomann CLA 2010-04-25 18:57:13 EDT 
Released for 3.6M7.
Regression tests added in:
org.eclipse.jdt.core.tests.compiler.regression.BatchCompilerTest#test305
org.eclipse.jdt.core.tests.compiler.regression.BatchCompilerTest#test306
Comment 5 Olivier Thomann CLA 2010-04-25 18:58:36 EDT 
*** Bug 260997 has been marked as a duplicate of this bug. ***
Comment 6 Frederic Fusier CLA 2010-04-27 08:18:21 EDT 
Verified for 3.6M7 using I20100425-2000.