Bug 309951 - [ui] "Details" group box is truncated
Summary: [ui] "Details" group box is truncated
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-04-21 09:25 EDT by Irem CLA
Modified: 2010-05-06 14:56 EDT (History)
3 users (show)

See Also:


Attachments
Show truncated groupbox (60.01 KB, image/jpeg)
2010-04-21 09:28 EDT, Irem CLA
no flags Details
build ID (32.27 KB, image/jpeg)
2010-04-21 09:49 EDT, Irem CLA
no flags Details
Screenshot depicting the problem in question. (113.70 KB, image/jpeg)
2010-05-06 14:10 EDT, Remy Suen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Irem CLA 2010-04-21 09:25:17 EDT
Build Identifier: 

When we go to "Help>Install New Software...", select a update site and a category, the "More" link in the "Details" group box is truncated. This happens in English and all languages.



Reproducible: Always
Comment 1 Pascal Rapicault CLA 2010-04-21 09:27:30 EDT
Coul you please:
- indicate which build this is on?
- attach a screenshot of the problem.
Comment 2 Irem CLA 2010-04-21 09:28:15 EDT
Created attachment 165571 [details]
Show truncated groupbox
Comment 3 Irem CLA 2010-04-21 09:49:22 EDT
Created attachment 165579 [details]
build ID
Comment 4 Remy Suen CLA 2010-04-21 11:57:38 EDT
I see this too on XP.
Comment 5 Susan McCourt CLA 2010-04-25 12:41:10 EDT
What I observe:
With a fresh workspace, this doesn't happen.
If you size the sash so that the details area is shorter, or if you size the dialog so that the details begins to clip, than this occurs.
The last-used dialog size is persisted, so if it clipped before (or if the code changed and the dialog grew), then this could happen.

I wonder if there are dialog settings stored from a previous release and now the dialog is layed out differently?

Can you please confirm if you are seeing this with a fresh workspace or an older one?
Comment 6 Susan McCourt CLA 2010-04-26 10:49:48 EDT
For 3.6, we should probably calculate the preferred size of wizards and use the larger of the stored setting and the preferred size.  This would be a one-time "migration" of dialog settings and after that the user size would always be used.
Comment 7 Susan McCourt CLA 2010-04-30 18:05:38 EDT
investigate for RC1
Comment 8 Susan McCourt CLA 2010-05-06 14:07:07 EDT
Remy, do you see this when you use a clean workspace?
I don't observe the problem on win7 unless I've previously saved a dialog size that causes this to happen (because the size and sash weights are remembered).

However this dialog has changed (has more controls) so an old height could cause new clipping.  I looked into the theory that this could penalize a 3.5->3.6 user, but it doesn't happen, because the dialog size is remembered according to fully qualified class name, and the class moved between 3.5 and 3.6.  So we aren't going to remember the size moving from 3.5 to 3.6 (which I don't plan to address at this point, even though it was not intended.)

It is possible that someone who had been running the 3.6 milestones and using the same workspace could get into this position, but not someone who is migrating from 3.5 to 3.6.

I'm inclined to say "WONTFIX" if this is simply a problem for those who followed the development of 3.6.

However if you do see a problem with a fresh workspace, then the problem is something entirely different.
Comment 9 Remy Suen CLA 2010-05-06 14:10:29 EDT
Created attachment 167357 [details]
Screenshot depicting the problem in question.

(In reply to comment #8)
> Remy, do you see this when you use a clean workspace?

Yes, this is what my screen looks like with I20100429-1549. My resolution is 1680x1050.
Comment 10 Remy Suen CLA 2010-05-06 14:11:44 EDT
(In reply to comment #9)
> Created an attachment (id=167357) [details]
> Screenshot depicting the problem in question.

Oh, my mistake. If I actually select something the 'More...' link is actually drawn properly.
Comment 11 Kit Lo CLA 2010-05-06 14:47:34 EDT
I reproduced the problem with a fresh workspace in one of the older build on XP. But, seems like it's fixed in I20100429-1549.
Comment 12 Susan McCourt CLA 2010-05-06 14:56:49 EDT
OK, I'll mark WORKSFORME (US?) for now.  
If anyone sees this again, please reopen.

The goal is that it looks good with a fresh workspace or a 3.5 or earlier workspace.  One could get in this state by using a workspace in, say, 3.6 M5 (after the class was moved) and then reusing it in 3.6 M7.