Community
Participate
Working Groups
In bug #309452 we requested the addition of the method clearExtraRequirements on ProfileChangeRequest. I'm now requesting the addition of the same method on the public interface called IProfileChangeRequest. This new method will allow users of the API to clear the requirements that they have added using addExtraRequirements(Collection) and will allow clients to not have to cast to the ProfileChangeRequest class which is scheduled to be moved to a new package in the next release of p2. Overall the addition of this new method has not risk (the interface is flagged @noextend, @noimplement) and will just fix an obvious miss.
Please attach a patch with javadoc to review. I am not sure I understand why we need the ability to clear extra requirements (additionalRequirements) on the API but do not need to be able to clear any of the other lists/maps that can be added to in the implementation of IProfileChangeRequest (iuPropertiesToAdd, iuPropertiesToRemove, iusToAdd, iusToRemove) Is this really needed outside of p2 at this point?
We discussed this for a bit on the Equinox call. To be clear, I don't think this is necessarily a risky change since the interface is marked @noimplement @noextend, but I question the need for this outside of p2. At this point the risk is in our confidence in the new method. We should only be adding API that is a must to fix some issue. 1) It is inconsistent from an API point of view to add the ability to clear only one of the lists/maps on the IProfileChangeRequest interface. 2) We are not sure if it is really needed outside of p2. Limiting the additional API at this point seems like a better option. We can always add it in another release if it ends up being needed.
> I am not sure I understand why we need the ability to clear extra requirements > (additionalRequirements) on the API but do not need to be able to clear any of > the other lists/maps that can be added to in the implementation of > IProfileChangeRequest (iuPropertiesToAdd, iuPropertiesToRemove, iusToAdd, > iusToRemove) The remove methods act like an add. > Is this really needed outside of p2 at this point? Not that I know of.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
