Bug 309542 - [api] Add API to Profile Change Request
Summary: [api] Add API to Profile Change Request
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-04-16 16:34 EDT by DJ Houghton CLA
Modified: 2010-04-19 10:20 EDT (History)
2 users (show)

See Also:
tjwatson: pmc_approved+
pascal: review+


Attachments
patch (913 bytes, patch)
2010-04-16 17:17 EDT, DJ Houghton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-04-16 16:34:47 EDT
Currently when you have a profile change request you are able to set additional requirements to the request but there is no way to remove them. 

We should consider adding #clearExtraRequirements() to either ProfileChangeRequest (currently provisional API) or to the IProfileChangeRequest interface.
Comment 1 DJ Houghton CLA 2010-04-16 17:17:51 EDT
Created attachment 165153 [details]
patch

Patch which adds new method #clearExtraRequirements to the class.
Comment 2 DJ Houghton CLA 2010-04-16 17:22:29 EDT
Adding Tom to the CC for PMC approval.

The request is to add a new method to a class in a provisional API package. (class will hopefully be made fully internal eventually, see bug 309539) We are adding the method to the class rather than the interface as we feel that this is not something that normal clients will use. (we plan on using it internally in p2) Should other clients request similar function, we can review that during our API review for the next release and consider moving it to the interface at that time.

Risk should be minimal. Although the class itself doesn't have markup, the interface that it implements is listed as noextend and noimplement.
Comment 3 Thomas Watson CLA 2010-04-16 18:06:39 EDT
I approve.
Comment 4 DJ Houghton CLA 2010-04-19 10:20:33 EDT
Released.