Bug 309156 - too many event object created in event queue
Summary: too many event object created in event queue
Status: RESOLVED WONTFIX
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-04-14 12:08 EDT by Michael Rennie CLA
Modified: 2010-08-17 02:00 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-04-14 12:08:05 EDT 
code from HEAD

Testing new events for bug 308330 I found that we create N event object when there are N requests for the event. We do this because we pas back the request object in the event. 

We should investigate not doing this, we should be creating 1 event and broadcasting it to all requestors (only place one event in the queue). The reasons for this are many, mostly:

1. smaller event queue size
2. smaller event / event packet size
3. less work sending events (less to iterate over)
4. faster event creation - we don't have to iterate over all requestors creating objects

etc.
Comment 1 Michael Rennie CLA 2010-04-23 09:55:16 EDT 
This is not going to happen for M7
Comment 2 Michael Rennie CLA 2010-08-17 02:00:57 EDT 
we looked at this in M1 and decided to leave it as is, one event for one request is fine, and a good way to avoid broadcasting events when we shouldn't be.

Marking wontfix (before I forget again)