Bug 309108 - [JSF2.0] Facelet Validator should use v2 extension
Summary: [JSF2.0] Facelet Validator should use v2 extension
Status: CLOSED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 M7   Edit
Assignee: Raghunathan Srinivasan CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-04-14 08:17 EDT by Xiaonan Jiang CLA
Modified: 2010-05-04 09:24 EDT (History)
3 users (show)

See Also:

Attachments
fix (6.55 KB, patch)
2010-04-14 08:18 EDT, Xiaonan Jiang CLA 		no flags Details | Diff
updated patch (6.57 KB, patch)
2010-04-15 14:08 EDT, Xiaonan Jiang CLA 		raghunathan.srinivasan: iplog+
raghunathan.srinivasan: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaonan Jiang CLA 2010-04-14 08:17:37 EDT 
Build Identifier: wtp 3.2

  Similar to bug 228298, the new Facelet validator should also use v2 extension. 

  V2 Validator framework will benefit the Facelet validator in both performance and functionality.

  Bug 228298 is marked as stop-ship or hotbug. This bugzilla has the same importance to facelet pages. We expect it in wtp 3.2. 
  
  

Reproducible: Always
Comment 1 Xiaonan Jiang CLA 2010-04-14 08:18:32 EDT 
Created attachment 164821 [details]
fix
Comment 2 Xiaonan Jiang CLA 2010-04-15 14:08:48 EDT 
Created attachment 165002 [details]
updated patch

Added the facet version number in the extension. The rule now becomes:
            <rules>
               <facet
                     id="jst.jsf" version="2.0">
               </facet>
            </rules>
Comment 3 Andrew McCulloch CLA 2010-04-21 14:56:25 EDT 
The patch looks good to me.
Comment 4 Raghunathan Srinivasan CLA 2010-04-21 19:34:44 EDT 
Patch committed to HEAD. Thanks, Xiaonan Jiang, for the patch
Comment 5 Xiaonan Jiang CLA 2010-05-04 09:24:43 EDT 
Works as expected.