Comment 1 Andrew Clement 2010-04-12 13:37:07 EDT

no doubt a regression related to the refactoring of generics handling.  Unfortunately all my tests work just fine and a sample project to try and recreate this works too.  Are you at all able to share the project with me (doesn't have to be in a public area like bugzilla) so that I can try to fix it?  Or distill down a small failing sample?

Comment 2 Andrew Clement 2010-04-12 16:58:59 EDT

With help from Cyprien I now have a minimal failing testcase.  With these types:

Middle.java
public abstract class Middle<E> extends Top<E> {
    class IteratorImpl extends TopInner { }
}

Top.java
public class Top<K> {
        class TopInner {
        public void hhh() { }
        }
}

Zzz.java
public abstract class Zzz<E> extends Middle<E> {
    void removeAll() {
        IteratorImpl it = new IteratorImpl();
        it.hhh();
    }
}

Aspy.aj
public aspect Aspy {
        before(): call(* *(..)) {       }
}

and this command line:

ajc -1.5 Aspy.aj Zzz.java Top.java Middle.java

java.lang.IllegalStateException: Can't ask to parameterize a member of non-generic type: Top$TopInner  kind(simple)
        at org.aspectj.weaver.ResolvedMemberImpl.parameterizedWith(ResolvedMemberImpl.java:676)
        at org.aspectj.weaver.ResolvedMemberImpl.parameterizedWith(ResolvedMemberImpl.java:664)
        at org.aspectj.weaver.ReferenceType.getDeclaredMethods(ReferenceType.java:772)
        at org.aspectj.weaver.ResolvedType.lookupMethod(ResolvedType.java:534)


I believe it is caused by the fact that the inner type is non directly generic but as it is the inner type of a generic type, it shouldn't be triggering the IllegalStateException (since it inherits the type variables).

Comment 3 Andrew Clement 2010-04-13 16:20:03 EDT

fixed - allows for this scenario now, it won't trigger the illegalstate.