Bug 308721 - Add toolbar for Source actions
Summary: Add toolbar for Source actions
Status: REOPENED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-10 03:43 EDT by Marc-André Laperle CLA
Modified: 2020-09-04 15:16 EDT (History)
1 user (show)

See Also:


Attachments
Patch adding the toolbar buttons in plugin.xml (3.77 KB, text/plain)
2010-04-10 03:43 EDT, Marc-André Laperle CLA
no flags Details
Icons to put in icons/elcl16 (1.05 KB, application/zip)
2010-04-10 03:46 EDT, Marc-André Laperle CLA
no flags Details
Screenshot of the toolbar (16.29 KB, image/png)
2010-04-10 18:22 EDT, Marc-André Laperle CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2010-04-10 03:43:56 EDT
Created attachment 164461 [details]
Patch adding the toolbar buttons in plugin.xml

In VS where there is a Text Editor tool bar containing:
-Comment
-Uncomment
-Shift left
-Shift right
-Others less important IMO

This especially helps beginners. I think it would be great to have something similar in CDT and more advanced users could still disable the tool bar.

CDT could have:
-Toggle Comment (//)
-Add block comment
-Remove block comment
(Toggle block comment would be better but it not available)
-Shift left
-Shift right
Comment 1 Marc-André Laperle CLA 2010-04-10 03:46:48 EDT
Created attachment 164462 [details]
Icons to put in icons/elcl16

Added the comment icons, updated shift_r_edit.gif because it was not properly aligned with the left.
Comment 2 Marc-André Laperle CLA 2010-04-10 03:49:36 EDT
I'm not sure how to set the order of the tool bars. I would definitely put it more to the right.
Comment 3 Marc-André Laperle CLA 2010-04-10 18:22:27 EDT
Created attachment 164478 [details]
Screenshot of the toolbar
Comment 4 Andrew Gvozdev CLA 2010-04-11 23:56:17 EDT
I think that the beginners are overwhelmed with all the eclipse options and not sure if adding more is a good thing. Toggle comment and the others are very useful and common operations but they are most useful when using keyboard shortcuts not toolbar. Users need a way to discover those - once, and I think "Source" menu is good enough. But I suppose I lost my beginner viewpoint a few years ago.
From my perspective, adding more buttons on the toolbar will make the toolbar to take two lines instead of one as I widen perspectives panel to keep open 4-5 perspective buttons for easier access.
Comment 5 Marc-André Laperle CLA 2010-04-12 02:19:36 EDT
(In reply to comment #4)
> I think that the beginners are overwhelmed with all the eclipse options and not
> sure if adding more is a good thing. Toggle comment and the others are very
> useful and common operations but they are most useful when using keyboard
> shortcuts not toolbar. Users need a way to discover those - once, and I think
> "Source" menu is good enough. But I suppose I lost my beginner viewpoint a few
> years ago.

I'm not convinced the toolbar should be added either but I've seen people coming from VS looking for this and just give up on the operations. Another issue with the actions is the key binding. Sometimes, on non-english keyboards, '/' and '\' have to be done with a modifier (shift, or other) so the binding doesn't work which leaves the user to use the menu every time or change the key bindings. I didn't change the bindings for a while thinking they were just broken.

I wish there were "UI profiles" matching the kind of user using it...

> From my perspective, adding more buttons on the toolbar will make the toolbar
> to take two lines instead of one as I widen perspectives panel to keep open 4-5
> perspective buttons for easier access.

I agree that if you leave all the default toolbars, it's too much. It would be nice to have the actions more obvious but yeah, it will clutter the UI too much. So, I won't pursue this idea further.

I've been also thinking that the Manage configurations button could be merged with the Build button so it would be more like Debug and Run configurations. The drop down would look like:

Debug
Release
---------------
Configuration...
Comment 6 Patrick McKelvy CLA 2016-09-15 05:34:28 EDT
This Visual Studio migrant argues that it should at least be possible to add a toolbar for Source actions, which appears to be an impossibility from what I can decipher from the altogether challenged user interface of Eclipse.

Whether the toolbar is there by default or not upon installation would seem to be an argument (posed by Andrew Gvozdev) that is besides the point, being a separate discussion altogether, as I see it.
Comment 7 Marc-André Laperle CLA 2016-09-18 23:37:32 EDT
I don't mind adding the toolbar and not enable it by default. Any objections?

Patrick, do you think my original proposal made sense? Or do you think some actions should be removed or added?
Comment 8 Patrick McKelvy CLA 2016-09-19 02:31:53 EDT
Wow, a proper answer on an open-source bug system. Thanks, Mr. Laperle, I am newly encouraged. :)

Your original proposal looks great. I have no problem with leaving it disabled by default, either: Mr. Gvozdev's opinion that there was little room available is certainly valid enough (but it would be great to have the option, as you and I [and others] would like).

Thanks for getting back and for the willingness to improve the situation!