Bug 308540 - [expressions][update policy][cdi] Disabled expressions are still evaluated.
Summary: [expressions][update policy][cdi] Disabled expressions are still evaluated.
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Pawel Piech CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-04-08 14:15 EDT by Pawel Piech CLA
Modified: 2010-04-09 12:54 EDT (History)
2 users (show)

See Also:
marc.khouzam: review+

Attachments
Patch with fix. (13.01 KB, patch)
2010-04-08 14:42 EDT, Pawel Piech CLA 		pawel.1.piech: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2010-04-08 14:15:13 EDT 
DSF expressins view does not pay attention to the Enable/Disable actions that are available for expressions in expressions view.  

As an alternative DSF does support update policies where the whole view can be stopped from updating.  However, this is not the same as disabling individual expressions and in fact the Enable/Disable actions are still visible, they just have no effect.
Comment 1 Pawel Piech CLA 2010-04-08 14:42:00 EDT 
Created attachment 164265 [details]
Patch with fix.

The fix adds a new class to the provisional VM API so I'll send a notification to cdt-dev.
Comment 2 Pawel Piech CLA 2010-04-08 14:44:13 EDT 
I committed the fix.  Marc, please give it a try when you get a chance.
Comment 3 Marc Khouzam CLA 2010-04-08 20:43:07 EDT 
(In reply to comment #2)
> I committed the fix.  Marc, please give it a try when you get a chance.

The code wasn't trivial, so looked it over quickly but I mostly tested things.
It works really well.  In fact, better than CDI.
Nice.
Comment 4 Marc Khouzam CLA 2010-04-09 12:49:05 EDT 
I noticed there is also a enable/disable menu in the variables view for CDI.  It is disabled for DSF.  Should I open a new bug or should we use this one for that too?
Comment 5 Pawel Piech CLA 2010-04-09 12:54:16 EDT 
That one is contributed by CDI (as opposed to by the platform).  As a matter of feature parity I suppose we should note it but I'm not sure if it would be as useful as the enable/disable in the expressions view.  In the least we should hide the action (and not just disable it).