Bug 308539 - Debug creates many ASTs with bindings on Save
Summary: Debug creates many ASTs with bindings on Save
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-04-08 14:10 EDT by Markus Keller CLA
Modified: 2010-04-12 13:25 EDT (History)
3 users (show)

See Also:
markus.kell.r: review+

Attachments
propoesed fix (5.88 KB, patch)
2010-04-09 14:41 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-04-08 14:10:02 EDT 
HEAD

The fix for bug 223315 is very expensive. On Save, you create 2 full ASTs with bindings for each breakpoint in the file, see BreakpointMarkerUpdater#updateMarker(IMarker, IDocument, Position)

See also bug 301113, though I'm not sure if you can also use the SharedASTProvider here.
Comment 1 Dani Megert CLA 2010-04-09 03:09:16 EDT 
Good catch! This is a must fix.
Comment 2 Michael Rennie CLA 2010-04-09 14:41:18 EDT 
Created attachment 164415 [details]
propoesed fix

Stops using the expensive creation code for getting an AST and switches to using SharedASTProvider. To bad there wasn't some way we could also avoid being called twice for each breakpoint...
Comment 3 Michael Rennie CLA 2010-04-09 15:20:05 EDT 
applied patch to HEAD, please verify Markus
Comment 4 Markus Keller CLA 2010-04-12 13:25:06 EDT 
Verified in N20100411-2000.